Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace wildcard import with single import #4138

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

Bambooin
Copy link
Contributor

@Bambooin Bambooin commented Apr 1, 2024

Description

Replace wildcard import with single import

Done with tool Optimize Imports from AS and fix the left one by one manually.

  • chore: replace wildcard import with single import
  • chore: enable no wildcard import rule

Issue tracker

Automatic tests

  • Added test cases

Manual tests

  • Done

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

@TranceLove TranceLove added the Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. label Apr 1, 2024
Done with tool `Optimize Imports` from AS and fix the left one by one manually.
@Bambooin
Copy link
Contributor Author

The build of Build debug and run Jacoco tests is very unstable, about 50% possibility.

So I hava to trigger twice or more due to rebase upstream patches.

@VishalNehra VishalNehra merged commit 29604c2 into TeamAmaze:release/4.0 Apr 21, 2024
3 checks passed
@VishalNehra VishalNehra added this to the v4.0 milestone Apr 21, 2024
@Bambooin Bambooin deleted the code-style branch April 21, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants