Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HeSD a subset of Type Ia #945

Open
reinhold-willcox opened this issue Mar 26, 2023 · 1 comment
Open

Make HeSD a subset of Type Ia #945

reinhold-willcox opened this issue Mar 26, 2023 · 1 comment
Assignees
@nrsegovia
Labels
enhancement New feature or request good first issue Good for newcomers urgency_low This issue is not urgent

Comments

@reinhold-willcox
Copy link
Collaborator

Following Ilya's suggestion in PR #822, the HeSD SN type should be a sub-class of Type Ia, identically to how USSNe are a subset of CCSNe.

This is non-urgent, but could be a good first problem for the interested new developer.
@reinhold-willcox reinhold-willcox added enhancement New feature or request good first issue Good for newcomers urgency_low This issue is not urgent labels Mar 26, 2023
@ilyamandel ilyamandel assigned ilyamandel and nrsegovia and unassigned ilyamandel Mar 26, 2023
@ilyamandel
Copy link
Collaborator

@reinhold-willcox -- I agree with making this a separate issue. In the meantime, congratulations to you and @solfreludio on completing #822 !

LCon0032 added a commit that referenced this issue Sep 11, 2023
@LCon0032
Merge pull request #994 from LCon0032/Issue945
a02fe2a 
Fix for Issue #945: Make HeSD SN Type a Subclass of SNIA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nrsegovia nrsegovia

Labels
enhancement New feature or request good first issue Good for newcomers urgency_low This issue is not urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ilyamandel @reinhold-willcox @nrsegovia