Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Praise the sun! (and other light emitting bodies) #209

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

g307m
Copy link
Contributor

@g307m g307m commented Dec 1, 2021

Fixes #208 and moves duplicate code from solar panels to an abstract class.

@g307m
Copy link
Contributor Author

g307m commented Dec 1, 2021

By the way, how do I hide the old commits?

@craftablescience
Copy link
Member

By the way, how do I hide the old commits?

You can use GitHub Desktop to squash all these commits into a singular commit, then force-push.

Alternatively, use git interactive rebasing.

@g307m
Copy link
Contributor Author

g307m commented Dec 1, 2021

Squashing. I'll do that in the future.

@g307m
Copy link
Contributor Author

g307m commented Dec 1, 2021

oh it decided to add that to the pr, didnt work

@g307m
Copy link
Contributor Author

g307m commented Dec 1, 2021

eh, i'll just nuke the fork later

@deltanedas
Copy link

git rebase -i HEAD~16

then make every commit after the first s instead of pick to squash them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solar panel stores negative energy at night
5 participants