Add asdict method that returns JSON-encodable object #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation object can still contain numpy objects (it may be faster and more convenient), transformation to plain python objects happens in
numpy_to_python
object.Transformation in
asdict
loses information anyway (at least it loses types of objects), but here another loss of information occurs forFormattedFeatureName
where we just take it'svalue
and can not distinguish formatted and not formatted feature names. I think that this might be better to make feature name a wrapper object in any case (we also have unhashed features represented as lists) - but then it's better to do it separately.