Merge pull request #107 from TomWagg/sampling

Fix sampling of inclination and polarisation

changelog.md

@@ -153,4 +153,9 @@ having two when we could just set `f_dom=2 f_orb`
 - [Issues [#102](https://github.com/TeamLEGWORK/LEGWORK/issues/102)] Make SNR functions notice when you change confusion noise
     - `Source.get_snr()` now takes all `sc_params` as arguments for re-interpolation etc
     - `Source.get_snr_stationary` and `Source.get_snr_evolving` have the same parameters added as above
-    - All functions in `snr` now take `**kwargs` that are passed directly to `psd.power_spectral_density` for maximum flexibility 
+    - All functions in `snr` now take `**kwargs` that are passed directly to `psd.power_spectral_density` for maximum flexibility 
+
+
+## 0.4.4
+*TW 14/09/22*
+- [Issues [#106](https://github.com/TeamLEGWORK/LEGWORK/issues/106)] Fix sampling of inclination and polarisation when they are not supplied to `Source`

legwork/_version.py

@@ -1 +1 @@
-__version__ = "0.4.3"
+__version__ = "0.4.4"

legwork/source.py

@@ -122,10 +122,12 @@ def __init__(self, m_1, m_2, ecc, dist, n_proc=1, f_orb=None, a=None, position=N
         else:
             if inclination is None:
                 print("Generating random values for source inclinations")
-                inclination = np.arcsin(np.random.uniform(-1, 1, len(m_1))) * u.rad
+                # inclination is sampled uniformly in cos(i) to get a range of [0, pi/2]
+                inclination = np.arccos(np.random.uniform(0, 1, len(m_1))) * u.rad
             if polarisation is None:
                 print("Generating random values for source polarisations")
-                polarisation = np.random.uniform(0, 2 * np.pi, len(m_1)) * u.rad
+                # polarisation is sampled from 0 to pi following Flanagan & Hughes 1998 (e.g. Eq. 2.34)
+                polarisation = np.random.uniform(0, np.pi, len(m_1)) * u.rad
 
         # ensure position is in the correct coordinate frame
         if position is not None: