Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make blood grinder take values from text file #317

Closed
flamechair opened this issue Jun 26, 2018 · 5 comments
Closed

Make blood grinder take values from text file #317

flamechair opened this issue Jun 26, 2018 · 5 comments
Labels
enhancement Any minor tweak that can be introduced in minor releases good first issue

Comments

@flamechair
Copy link

Versions

  • Minecraft: 1.12.2
  • Forge: 1.12.2 2705
  • Vampirism: Vampirism-1.12.2-1.4.2

Additional Information

The way you designed the custom defined blood values for sucking blood works fantastic, and it would be a great addition to implement the same system for what types of meat can be put inside the blood grinder so we can add other mod's meats in there.

Also Beef/Pork are included by default, but not Mutton. Is this intended?

@maxanier maxanier added the enhancement Any minor tweak that can be introduced in minor releases label Jun 27, 2018
maxanier pushed a commit that referenced this issue Aug 3, 2018
Alright, merging this now, things that are still left TODO as discussed:
- Thickness of vampire cloak.
- Smaller number of different vampire cloaks with more fitting textures.

Closes #323, #317, #316 and #308. By @Cheaterpaul
@maxanier maxanier closed this as completed Aug 3, 2018
@Teibidh
Copy link

Teibidh commented Feb 29, 2020

I don't see a reference to this in the documentation, what is the filename and format to use for adding modded meat to the grinder?

@Cheaterpaul
Copy link
Member

in 1.12 you can add the file vampirism_blood_values_grinder.txt to the vampirism config directory with the same pattern as https://github.com/TeamLapen/Vampirism/blob/1.12/src/main/resources/blood_values_grinder/default_blood_values.txt and/or submit the values

@maxanier
Copy link
Member

maxanier commented Mar 1, 2020

@Cheaterpaul maybe you can update the wiki for 1.14 if you have some spare time https://github.com/TeamLapen/Vampirism/wiki/Biteable-Creatures-Blood-Grinder#114 and provide an example in https://github.com/TeamLapen/VampirismDatapackExamples.
I can't remember how it works, actually

@Cheaterpaul
Copy link
Member

Cheaterpaul commented Mar 1, 2020

i didn't know you can use IMC messages to register blood values
sending IMC messages about the blood values have no effect at the moment

@maxanier
Copy link
Member

maxanier commented Mar 1, 2020

I think that is fine, should be clear from the updated wiki.
Data packs should work as good

maxanier pushed a commit to maxanier/Vampirism that referenced this issue Oct 23, 2020
Alright, merging this now, things that are still left TODO as discussed:
- Thickness of vampire cloak.
- Smaller number of different vampire cloaks with more fitting textures.

Closes TeamLapen#323, TeamLapen#317, TeamLapen#316 and TeamLapen#308. By @Cheaterpaul
maxanier pushed a commit to maxanier/Vampirism that referenced this issue Oct 23, 2020
Alright, merging this now, things that are still left TODO as discussed:
- Thickness of vampire cloak.
- Smaller number of different vampire cloaks with more fitting textures.

Closes TeamLapen#323, TeamLapen#317, TeamLapen#316 and TeamLapen#308. By @Cheaterpaul
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any minor tweak that can be introduced in minor releases good first issue
Projects
None yet
Development

No branches or pull requests

4 participants