Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [FEAT] 질문 스레드에서 텍스트뷰에 링크가 포함되어있을 때 하이퍼링크로 변환 #390

Merged

Conversation

hwangJi-dev
Copy link
Member

🍎 관련 이슈

closed #389

🍎 변경 사항 및 이유

  • SafariService를 이용하여 SafariVC로 이동하는 함수를 BaseVC로 빼서 관련 함수를 사용하는 코드들을 정리했습니다.
    수정된 VC : AgreeTermsVC, ReviewMainVC, InfoDetailVC, DefaultQuestionChatVC, SettingAppInfoVC

🍎 PR Point

  • 질문 스레드에서 텍스트뷰에 링크가 포함되어있을 때 하이퍼링크로 변환하는 기능을 추가했습니다~

📸 ScreenShot

@hwangJi-dev hwangJi-dev added 🍎 Feature 새로운 기능 개발시 사용합니다. ⚡️ HotFix 급한 수정시 사용합니다. ✨🍕 Jieun 🐰✨ 지은이 연 pr, issue에 사용 ✏️ 과방탭 과방탭 개발시 사용합니다. labels Mar 24, 2022
@hwangJi-dev hwangJi-dev self-assigned this Mar 24, 2022
@hwangJi-dev hwangJi-dev added this to In progress in NadoSunbae-iOS for release✨ via automation Mar 24, 2022
@hwangJi-dev hwangJi-dev added this to In progress in ✨ NadoSunbae ✨ via automation Mar 24, 2022
Copy link
Member

@dev-jungbin dev-jungbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인선배~

@@ -272,6 +273,12 @@ extension BaseVC {
completion(questionDetailVC)
self.navigationController?.pushViewController(questionDetailVC, animated: true)
}

/// SafariViewController를 불러와 present 화면전환을 하는 메서드 (인앱)
func presentToSafariVC(url: URL) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와씨나도이거써야겟다
감사륑

@@ -98,4 +97,10 @@ extension ClassroomCommentTVC: UITextViewDelegate {
delegate.updateTextViewHeight(cell: self, textView: textView)
}
}

/// shouldInteractWith URL - 텍스트뷰 내 link와 interact하는 메서드
func textView(_ textView: UITextView, shouldInteractWith URL: URL, in characterRange: NSRange, interaction: UITextItemInteraction) -> Bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

화긴

Copy link
Member

@jane1choi jane1choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인!! 수고해써👍🏻🔥

@hwangJi-dev hwangJi-dev merged commit 80a6040 into develop Mar 25, 2022
✨ NadoSunbae ✨ automation moved this from In progress to Done Mar 25, 2022
NadoSunbae-iOS for release✨ automation moved this from In progress to Done Mar 25, 2022
@dev-jungbin dev-jungbin deleted the feature/#389-Classroom-QuestionDetail-TextViewLink branch August 24, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ 과방탭 과방탭 개발시 사용합니다. 🍎 Feature 새로운 기능 개발시 사용합니다. ⚡️ HotFix 급한 수정시 사용합니다. ✨🍕 Jieun 🐰✨ 지은이 연 pr, issue에 사용
Development

Successfully merging this pull request may close these issues.

✨ [FEAT] 질문 스레드에서 텍스트뷰에 링크가 포함되어있을 때 하이퍼링크로 변환
3 participants