✨[FEAT] 바텀시트 내 검색기능 구현 #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-jungbin
approved these changes
Sep 18, 2022
Comment on lines
+158
to
+163
| self.dataSource = UITableViewDiffableDataSource<Section, MajorInfoModel>(tableView: self.majorTV) { (tableView, indexPath, majorName) -> UITableViewCell? in | ||
| guard let cell = tableView.dequeueReusableCell(withIdentifier: MajorTVC.className, for: indexPath) as? MajorTVC else { preconditionFailure() } | ||
|
|
||
| cell.cellType = self.cellType | ||
| cell.setData(majorName: majorName) | ||
| return cell |
There was a problem hiding this comment.
오 기존 DataSource 대신 이렇게 사용하는구나`!!!
hwangJi-dev
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍎 관련 이슈
closed #460
🍎 변경 사항 및 이유
바텀시트 내 검색기능을 구현했습니다.
🍎 PR Point
UITableViewDiffableDataSource를 이용해 검색어가 바뀔 때마다 검색결과에 반영될 수 있도록 검색 기능을 구현했습니다.UITableViewDiffableDataSource 공식문서
UITableViewDiffableDataSource요 친구가UITableViewDataSource를 대체하기 때문에 기존UITableViewDataSourceextension을 다 삭제해주었습니다 참고해주세요!📸 ScreenShot
Simulator.Screen.Recording.-.iPhone.11.-.2022-09-15.at.20.49.53.mp4