Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ [CHORE] NadoAlert UI 수정 #529

Merged
merged 2 commits into from
Oct 12, 2022
Merged

✅ [CHORE] NadoAlert UI 수정 #529

merged 2 commits into from
Oct 12, 2022

Conversation

dev-jungbin
Copy link
Member

🍎 관련 이슈

closed #528

🍎 변경 사항 및 이유

  • Label 줄 수 대응
  • Label top, bottom 마진 조정

📸 ScreenShot

1줄 2줄
스크린샷 2022-10-11 오후 3 09 01 스크린샷 2022-10-11 오후 2 44 45
3줄 4줄
스크린샷 2022-10-11 오후 2 33 38 스크린샷 2022-10-11 오후 2 34 07
with TextField
스크린샷 2022-10-11 오후 2 43 03

@dev-jungbin dev-jungbin added 📱 View 뷰 개발(디자이닝)시 사용합니다. ❤️ 정빈걸 ❤️ 정빈이 연 pr, issue에 사용 ✅ Chore 자잘한 수정 시 사용합니다. labels Oct 11, 2022
@dev-jungbin dev-jungbin self-assigned this Oct 11, 2022
@dev-jungbin dev-jungbin added this to In progress in NadoSunbae-iOS for release✨ via automation Oct 11, 2022
@dev-jungbin dev-jungbin added this to In progress in ✨ NadoSunbae ✨ via automation Oct 11, 2022
hwangJi-dev
hwangJi-dev approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@hwangJi-dev hwangJi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜멋있당 ㅋㅋㅋㅋㅋㅋ 고생해쏘

jane1choi
jane1choi approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@jane1choi jane1choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아이 야물딱져

@dev-jungbin dev-jungbin merged commit 95da90e into develop Oct 12, 2022
✨ NadoSunbae ✨ automation moved this from In progress to Done Oct 12, 2022
NadoSunbae-iOS for release✨ automation moved this from In progress to Done Oct 12, 2022
@dev-jungbin dev-jungbin deleted the chore/#528-NadoAlert-UI branch October 12, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwangJi-dev hwangJi-dev hwangJi-dev approved these changes

@jane1choi jane1choi jane1choi approved these changes

Assignees

@dev-jungbin dev-jungbin

Labels
✅ Chore 자잘한 수정 시 사용합니다. ❤️ 정빈걸 ❤️ 정빈이 연 pr, issue에 사용 📱 View 뷰 개발(디자이닝)시 사용합니다.
Projects
NadoSunbae-iOS for release✨
Done
✨ NadoSunbae ✨
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✅ [CHORE] NadoAlert UI 수정
3 participants
@dev-jungbin @hwangJi-dev @jane1choi