Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [FEAT] 질문가능선배 리스트뷰 EmptyView 구현 #572

Merged
merged 9 commits into from
Oct 25, 2022

Conversation

hwangJi-dev
Copy link
Member

@hwangJi-dev hwangJi-dev commented Oct 24, 2022

🍎 관련 이슈

closed #571

🍎 변경 사항 및 이유

  • AvailableQuestionPersonEmptyCVC를 상속 가능하도록 final 키워드를 삭제하고 프로퍼티와 메서드의 접근지정자를 변경해주었습니다.
  • AvailableQuestionPersonEmptyCVC를 상속하여 QuestionPersonEmptyLabelCVC를 생성하였습니다.

🍎 PR Point

  • 질문가능선배 리스트뷰 EmptyView를 구현했습니다.
  • 커밋은 #571번만 봐주세요!

📸 ScreenShot

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2022-10-24.at.20.54.17.mp4

@hwangJi-dev hwangJi-dev added 📱 View 뷰 개발(디자이닝)시 사용합니다. ✨🍕 Jieun 🐰✨ 지은이 연 pr, issue에 사용 ✏️ 과방탭 과방탭 개발시 사용합니다. labels Oct 24, 2022
@hwangJi-dev hwangJi-dev self-assigned this Oct 24, 2022
@hwangJi-dev hwangJi-dev added this to In progress in ✨ NadoSunbae ✨ via automation Oct 24, 2022
@hwangJi-dev hwangJi-dev added this to In progress in NadoSunbae-iOS for release✨ via automation Oct 24, 2022
Copy link
Member

@jane1choi jane1choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항 바로 대응 짱이네요..멋지다..! 수고했어요~!

Copy link
Member

@dev-jungbin dev-jungbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했으요~~

@@ -7,7 +7,7 @@

import UIKit

class QuestionEmptyTVC: UITableViewCell {
final class QuestionEmptyTVC: UITableViewCell {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우앙굿 나도 보이는 대로 처리해야게따...

@hwangJi-dev hwangJi-dev merged commit 96238f7 into develop Oct 25, 2022
✨ NadoSunbae ✨ automation moved this from In progress to Done Oct 25, 2022
NadoSunbae-iOS for release✨ automation moved this from In progress to Done Oct 25, 2022
@hwangJi-dev hwangJi-dev deleted the feature/#571-availableQuestionPerson-emptyView branch October 25, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ 과방탭 과방탭 개발시 사용합니다. ✨🍕 Jieun 🐰✨ 지은이 연 pr, issue에 사용 📱 View 뷰 개발(디자이닝)시 사용합니다.
Development

Successfully merging this pull request may close these issues.

✨ [FEAT] 질문가능선배뷰 EmptyView 구현
3 participants