Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”จ [FIX] ํ™ˆ-์ปค๋ฎค๋‹ˆํ‹ฐ, ๋งˆ์ดํŽ˜์ด์ง€ TableView Height ๋ชป ์žก๋Š” ๋ฌธ์ œ ์ˆ˜์ • #601

Merged
merged 5 commits into from
Oct 26, 2022

Conversation

dev-jungbin
Copy link
Member

๐ŸŽ ๊ด€๋ จ ์ด์Šˆ

closed #592

๐ŸŽ ๋ณ€๊ฒฝ ์‚ฌํ•ญ ๋ฐ ์ด์œ 

  • ํ™ˆ ๋ทฐ์—์„œ ์ตœ๊ทผ ์ปค๋ฎค๋‹ˆํ‹ฐ ๊ธ€ ํ…Œ์ด๋ธ”๋ทฐ ๋งˆ์ง€๋ง‰ ๋ถ€๋ถ„์ด ์ž˜๋ฆฌ๋˜ ๋ฌธ์ œ๋ฅผ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • ๋งˆ์ดํŽ˜์ด์ง€ > ๋‚ด๊ฐ€ ์“ด ๊ธ€์—์„œ ํŠน์ • ๊ฐœ์ˆ˜์˜ ๋ฐ์ดํ„ฐ๊ฐ€ ์žˆ์„ ๋•Œ ์Šคํฌ๋กค ์•ˆ ๋˜๋˜ ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋งˆ์ดํŽ˜์ด์ง€ > ๋‚ด๊ฐ€ ์“ด ๊ธ€ > ์ปค๋ฎค๋‹ˆํ‹ฐ > ์ปค๋ฎค๋‹ˆํ‹ฐ ์ƒ์„ธ๋ณด๊ธฐ์— ์ง„์ž…ํ–ˆ๋‹ค๊ฐ€ ๋’ค๋กœ ๋Œ์•„๊ฐ”์„ ๋•Œ ์ œ๋Œ€๋กœ ๋กœ๋“œ๋˜์ง€ ์•Š๋˜ ๋ฌธ์ œ๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์„ ๋ฐฐ ๊ฐœ์ธํŽ˜์ด์ง€ 1:1 ์งˆ๋ฌธ์—์„œ ํ…Œ์ด๋ธ”๋ทฐ ๋งˆ์ง€๋ง‰ ๋ถ€๋ถ„์ด ์ž˜๋ฆฌ๋˜ ๋ฌธ์ œ๋ฅผ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๐ŸŽ PR Point

  • ํ…Œ์ด๋ธ”๋ทฐ ๋†’์ด ๊ฐœ๋นก์นœ๋‹ค..:)

@dev-jungbin dev-jungbin added ๐Ÿž Bug ์˜ˆ๊ธฐ์น˜ ์•Š์€ ๋ฌธ์ œ ๋˜๋Š” ์˜๋„ํ•˜์ง€ ์•Š์€ ๋™์ž‘(๋ฒ„๊ทธ) ๋ฐœ์ƒ ์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. โค๏ธ ์ •๋นˆ๊ฑธ โค๏ธ ์ •๋นˆ์ด ์—ฐ pr, issue์— ์‚ฌ์šฉ ๐Ÿ™‹๐Ÿปโ€โ™€๏ธ ๋งˆ์ดํŽ˜์ด์ง€ํƒญ ๋งˆ์ดํŽ˜์ด์ง€ํƒญ ๊ฐœ๋ฐœ์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. โœ… Chore ์ž์ž˜ํ•œ ์ˆ˜์ • ์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. ๐Ÿ›  QA QA ๋ฐ˜์˜์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. ๐Ÿ“ฐ ํ™ˆ ํƒญ ํ™ˆ ํƒญ ๊ฐœ๋ฐœ ์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. labels Oct 26, 2022
@dev-jungbin dev-jungbin self-assigned this Oct 26, 2022
@dev-jungbin dev-jungbin added this to In progress in โœจ NadoSunbae โœจ via automation Oct 26, 2022
@dev-jungbin dev-jungbin added this to In progress in NadoSunbae-iOS for releaseโœจ via automation Oct 26, 2022
Copy link
Member

@jane1choi jane1choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค!!!

@dev-jungbin dev-jungbin merged commit 947b436 into develop Oct 26, 2022
โœจ NadoSunbae โœจ automation moved this from In progress to Done Oct 26, 2022
NadoSunbae-iOS for releaseโœจ automation moved this from In progress to Done Oct 26, 2022
@dev-jungbin dev-jungbin deleted the fix/#592-Home-Mypage-TableViewHeight-UI branch October 26, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โœ… Chore ์ž์ž˜ํ•œ ์ˆ˜์ • ์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. โค๏ธ ์ •๋นˆ๊ฑธ โค๏ธ ์ •๋นˆ์ด ์—ฐ pr, issue์— ์‚ฌ์šฉ ๐Ÿž Bug ์˜ˆ๊ธฐ์น˜ ์•Š์€ ๋ฌธ์ œ ๋˜๋Š” ์˜๋„ํ•˜์ง€ ์•Š์€ ๋™์ž‘(๋ฒ„๊ทธ) ๋ฐœ์ƒ ์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. ๐Ÿ“ฐ ํ™ˆ ํƒญ ํ™ˆ ํƒญ ๊ฐœ๋ฐœ ์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. ๐Ÿ™‹๐Ÿปโ€โ™€๏ธ ๋งˆ์ดํŽ˜์ด์ง€ํƒญ ๋งˆ์ดํŽ˜์ด์ง€ํƒญ ๊ฐœ๋ฐœ์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. ๐Ÿ›  QA QA ๋ฐ˜์˜์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค.
2 participants