Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”จ [FIX] ๋ถ€์ ์ ˆ ํ›„๊ธฐ ์ž‘์„ฑ์ž ์ตœ์ดˆ 1ํšŒ ์•Œ๋Ÿฟ ๋œฌ ํ›„ ํ›„๊ธฐ ๋ฏธ์ž‘์„ฑ์ž ๊ถŒํ•œ์œผ๋กœ ๊ฐ•๋“ฑํ•˜๋„๋ก ์ฝ”๋“œ ์ˆ˜์ • #619

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

hwangJi-dev
Copy link
Member

๐ŸŽ ๊ด€๋ จ ์ด์Šˆ

closed #618

๐ŸŽ PR Point

  • ๋ถ€์ ์ ˆ ํ›„๊ธฐ ์ž‘์„ฑ์ž ์ตœ์ดˆ 1ํšŒ ์•Œ๋Ÿฟ ๋œฌ ํ›„ ํ›„๊ธฐ ๋ฏธ์ž‘์„ฑ์ž ๊ถŒํ•œ์œผ๋กœ ๊ฐ•๋“ฑํ•˜๋„๋ก UserPermissionInfo์˜ isReviewInappropriate ๊ฐ’์„ false๋กœ ๋ฐ”๊ฟ”์ฃผ์—ˆ์Šต๋‹ˆ๋‹ค!

๐Ÿ“ธ ScreenShot

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2022-10-27.at.01.37.21.mp4

@hwangJi-dev hwangJi-dev added โšก๏ธ HotFix ๊ธ‰ํ•œ ์ˆ˜์ •์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. โœจ๐Ÿ• Jieun ๐Ÿฐโœจ ์ง€์€์ด ์—ฐ pr, issue์— ์‚ฌ์šฉ ๐Ÿ›  QA QA ๋ฐ˜์˜์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. labels Oct 26, 2022
@hwangJi-dev hwangJi-dev self-assigned this Oct 26, 2022
@hwangJi-dev hwangJi-dev added this to In progress in โœจ NadoSunbae โœจ via automation Oct 26, 2022
@hwangJi-dev hwangJi-dev added this to In progress in NadoSunbae-iOS for releaseโœจ via automation Oct 26, 2022
Copy link
Member

@dev-jungbin dev-jungbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•— ์—ฌ๊ธฐ ๊ฐ€์„œ ํ•ด์คฌ๊ตฌ๋‚ญ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค..ใ…Žใ…Žใ…Ž

@hwangJi-dev hwangJi-dev merged commit b16d1a2 into develop Oct 26, 2022
โœจ NadoSunbae โœจ automation moved this from In progress to Done Oct 26, 2022
NadoSunbae-iOS for releaseโœจ automation moved this from In progress to Done Oct 26, 2022
@hwangJi-dev hwangJi-dev deleted the qa/#618-inappropriateReviewer-fix branch October 26, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โšก๏ธ HotFix ๊ธ‰ํ•œ ์ˆ˜์ •์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. โœจ๐Ÿ• Jieun ๐Ÿฐโœจ ์ง€์€์ด ์—ฐ pr, issue์— ์‚ฌ์šฉ ๐Ÿ›  QA QA ๋ฐ˜์˜์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค.
2 participants