Skip to content

Commit

Permalink
Merge pull request #3828 from wb9688/checkstyle-fix
Browse files Browse the repository at this point in the history
Do not include Checkstyle in any APK
  • Loading branch information
TobiGr committed Jun 30, 2020
2 parents d910091 + a7e8f50 commit c2b4a44
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ ext {
markwonVersion = '4.3.1'
}

configurations {
checkstyle
ktlint
}

checkstyle {
configFile rootProject.file('checkstyle.xml')
ignoreFailures false
Expand All @@ -106,8 +111,7 @@ task runCheckstyle(type: Checkstyle) {
exclude '**/BuildConfig.java'
exclude 'main/java/us/shandian/giga/**'

// empty classpath
classpath = files()
classpath = configurations.checkstyle

showViolations true

Expand All @@ -117,10 +121,6 @@ task runCheckstyle(type: Checkstyle) {
}
}

configurations {
ktlint
}

task runKtlint(type: JavaExec) {
main = "com.pinterest.ktlint.Main"
classpath = configurations.ktlint
Expand All @@ -143,7 +143,7 @@ dependencies {
implementation "frankiesardo:icepick:${icepickVersion}"
kapt "frankiesardo:icepick-processor:${icepickVersion}"

debugImplementation "com.puppycrawl.tools:checkstyle:${checkstyleVersion}"
checkstyle "com.puppycrawl.tools:checkstyle:${checkstyleVersion}"
ktlint "com.pinterest:ktlint:0.35.0"

debugImplementation "com.facebook.stetho:stetho:${stethoVersion}"
Expand Down

0 comments on commit c2b4a44

Please sign in to comment.