Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include Checkstyle in any APK #3828

Merged
merged 1 commit into from Jun 30, 2020
Merged

Do not include Checkstyle in any APK #3828

merged 1 commit into from Jun 30, 2020

Conversation

wb9688
Copy link
Contributor

@wb9688 wb9688 commented Jun 28, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Currently unnecessary Checkstyle stuff is included in debug APKs. I changed build.gradle to not include that stuff in the debug APKs, while it still runs Checkstyle. This causes debug APKs to be like 8 MB smaller.

Agreement

@wb9688 wb9688 added this to the 0.19.6 milestone Jun 28, 2020
@TobiGr TobiGr merged commit c2b4a44 into TeamNewPipe:dev Jun 30, 2020
This was referenced Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants