Small fixes of issues with old devices support, brightness, etc #4272

avently · 2020-09-11T18:10:59Z

What is it?

Bug fix (user facing)

Description of the changes in your PR

Some very small issues were fixed by this PR.

I don't like this thing https://github.com/TeamNewPipe/NewPipe/compare/dev...avently:small-fixes2?expand=1#diff-20e0b2ce67b307277c153b396fb79660R355 but making the height anything but wrap content makes red dot in progress bar misaligned on Android 4.4, see a few minor bugs #4245. With default height progress bar has smaller touchable area but looks ok on old devices too.
this thing https://github.com/TeamNewPipe/NewPipe/compare/dev...avently:small-fixes2?expand=1#diff-57eb59a31e38fed8f965fb4a544e3b9fR540 prevents freeze on 4.4. Looks like some devices have even less available size for storing bundle data than Google recommends, see [unified player] everything crashes after playing a video on fullscreen #4230. Anyway, this is how it should work and I'm fine with it
brightness will be saved in the place where it changes.

Fixes the following issue(s)

closes #4271
closes #4253
closes #4245
closes #4230
closes #4277
closes #4143
closes #4294
closes #4292
closes #4322

Testing apk

find the testing apk somewhere in this page because it's changes often

Agreement

I carefully read the contribution guidelines and agree to them.

MD77MD · 2020-09-11T18:44:27Z

brightness levels work ok now👌

opusforlife2 · 2020-09-12T07:57:16Z

@avently The seekbar jumps up a pixel in this as well. To be clear, it's not just the seekbar that moves. The two timers and the fullscreen button also move with it. The whole bottom setup also shrinks by a pixel on either side, I just noticed.

avently · 2020-09-12T08:43:41Z

@opusforlife2 it's probably happens because in the app status bar in landscape mode and have one size, then you move out of the app, the status bar in portrait and it's larger, when you move Into the app again, status bar in landscape again. So the whole view will be repositioned on every such situation. And there are more elements like navigation bar make a difference.

Anyway:

this is not caused by this PR
I will never do anything with it, even will not try.

opusforlife2 · 2020-09-12T09:06:56Z

this is not caused by this PR

Neve said it was.

I will never do anything with it, even will not try.

It's not worth fixing anyway. I just noticed it when I was comparing padding between blackbox's PR and the latest unified debug, so I asked.

avently · 2020-09-12T09:23:31Z

@opusforlife2

Neve said it was.

I never said that you said:)

I said it just for future reviewers of the PR. So it means that this PR is fine.

It's not worth fixing anyway.

Actually I thought you'll open an issue but you agree with me. Bravo! It was unexpected :)

MD77MD · 2020-09-12T12:01:15Z

🤣🤣🤣 both of you guys are just hilarious especially avently

avently · 2020-09-14T00:00:38Z

Added a commit related to Android 11 #4277. There is still a problem with overlapping thin navigation bar but I didn't fix it because it is already fixed but unreleased in #4255

avently · 2020-09-15T12:13:24Z

I have something interesting today. After I initially made this https://github.com/TeamNewPipe/NewPipe/blob/dev/app/src/main/java/org/schabi/newpipe/player/VideoPlayerImpl.java#L1492
I thought it's too complex thing to maintain but I didn't find another way. Make once right and you never need to touch this black box. But from time-to-time we see new issues related to this code. After I saw how much needed to be done in order to make my code working here #4255 I couldn't sit back and relax and started to search an alternative.

So I found a new (old) way of how player positioning should work. It doesn't need to have all these manual calculations. It just works (almost identical to 0.19.8).

I checked in portrait/landscape, vertical/non-verical videos, with/without cutout, on 4.4 (emulator), 9, 11 (emulator), on Android TV (only a little bit), in multiWindow mode. Maybe some bugs still present on real devices, can't say.

It's not a small fix so it shouldn't be in this PR but since I started to work in that branch I left it as is. I can create a new PR with just this one commit if you want but this commit uses the changes from this PR anyway.

As I said, it works like in 0.19.8 but I don't like how shadow covers the player. Shadow should be reimagined too but not from me or not now 100%. For non-cutout the shadow works ok, but for cutouts it isn't as good as I want it to be.

Let me know if some bugs are present.

@opusforlife2 @TobiGr @Stypox @blackbox87 @wb9688 @B0pol
@ZeroPucks

positioning.zip

Edit: updated version with a perfect shadow:
position-and-shadow.zip

opusforlife2 · 2020-09-15T12:38:20Z

Sorry, it's not exactly clear what you've changed from a user perspective. Can you clarify what to test?

Stypox · 2020-09-15T12:47:21Z

@avently with that positioning APK on Huawei P9 lite android 7.0, the controls go behind the system ui (hardware buttons and top dropdown menu indicator) instead of being constrained by them

avently · 2020-09-15T12:54:26Z

@opusforlife2 we have a video view that should be located under status bar and navigation bar in landscape, under status bar in multiwindow mode, away of statusbar in portrait.
We have controls (top and bottom menu buttons/position slider, fullscreen button that located inside the player view). And the controls should be accessible in any orientation, device size, device type, with or without cutout, etc. So the controls shouldn't be overlapped by other visual elements.

So if you see some button/control is inaccessible or located at a wrong position in the player view it means you find a bug.

avently · 2020-09-15T13:12:38Z

@Stypox but this device doesn't have hardware buttons, only virtual buttons.

Can you show a screenshot?

avently · 2020-09-15T13:44:35Z

@Stypox I installed Android 7.0 emulator and everything works fine, how to reproduce the issue you reported?

opusforlife2 · 2020-09-15T15:10:51Z

Alright. I have a simple display. Hardware buttons and no cutouts/notches. Here's my testing comparing base unified and positioning apks:

Positioning: when you tap to show player controls and rotate to landscape, you can see that after the status bar hides itself, the shadow doesn't extend to cover that area, leaving a weird bright rectangle until the controls fade out.
Unified: the shadow correctly extends to that area.

This happens with auto-rotate both off and on.

That's it! That's the only bug I found.

People with cutouts/notches/navigation bars may have other issues, though, so I suggest trying this experiment in a separate Issue, and if it works out, a PR later.

Stypox · 2020-09-15T15:28:41Z

but this device doesn't have hardware buttons, only virtual buttons.

Yeah, sorry, I meant those buttons. Anyway, I can't reproduce. Either I tested the wrong app (though I am pretty sure I tapped on "Open" after having installed the apk you provided), or who knows. I didn't do anything strange to create the situation I described above, I just tapped on a random video in trending and tapped on the fullscreen button.
@avently

avently · 2020-09-15T17:01:36Z

@opusforlife2

when you tap to show player controls and rotate to landscape, you can see that after the status bar hides itself, the shadow doesn't extend to cover that area, leaving a weird bright rectangle until the controls fade out.

but I don't like how shadow covers the player. Shadow should be reimagined too but not from me or not now 100%

Fiiine. Made a perfect shadow. Shadow of all shadows!
If no problem will be found, the PR can be merged.

@Stypox

Anyway, I can't reproduce

or who knows.

For me with every configuration and on any devices I test the app works perfectly.
In this apk:

perfect shadow. No one has this shadow but you.

position-and-shadow.zip

MD77MD · 2020-09-26T22:41:36Z

ok so @avently I tried this apk #4272 (comment) and got the same result as #4272 (comment) ... although the video would go back playing normal if you return the aspect ratio to fit... moreover, normal landscape videos don't suffer from this problem, on the other hand, probably because all three aspect modes have no effect what's so ever... perhaps we can test this if there is a landscape video with a weird aspect ratio.

also want to listen @MD77MD feedback on these two issues.

do you mean by the second issue the brightness issue?

p.s: testing device.. galaxy s4 - android 4.4

avently · 2020-09-26T22:50:07Z

do you mean by the second issue the brightness issue?

This one:
#4272 (comment)

Also let me know how to reproduce the brightness issue.

And thank you for the testing. Looks like the only thing I can do is to disable ZOOM mode for KitKat devices... so this mode will act like FIT mode.

MD77MD · 2020-09-26T22:58:46Z

I don't know about that. Could you describe the steps I need to do in order to reproduce the issue?

@avently I have been trying for the past week to catch the exact steps to reproduce this bug but failed. however this is the closest I got:

open a video and set brightness lets say 40 or 70% ... close or pause the video
switch to another app (maybe do some stuff)
go back to newPipe
open any video in landscape mode... the video will start playing using the same last brightness you used (everything is fine until now)
the bug: if you would try increase the brightness the screen brightness would suddenly drop and the slider would starts to increase from 0% even if the last value was greater.

expected behavior: when changing brightness... it would start from the same exact point used on the last video.

avently · 2020-09-26T23:54:15Z

@MD77MD

the bug: if you would try increase the brightness the screen brightness would suddenly drop and the slider would starts to increase from 0% even if the last value was greater.

This can happen before this PR and I fixed such situation here. Are you sure you see such behavior in final2.zip?

- the app will not rotate the screen to portrait after video completes, it will just exit from fullscreen mode - ability to rotate the orientation via fullscreen button from landscape to portrait when device has locked orientation in landscape - ability to enter/exit to/from fullscreen on tablets with unlocked global orientation in portrait mode

avently · 2020-09-27T01:37:07Z

In this apk:

fixed (Unified player) Unexpected behaviour upon tapping fullscreen button after video ends #4322
fixed Small fixes of issues with old devices support, brightness, etc #4272 (comment)
fixed (KitKat specific probably) this bug -> Also there is a problem related to portrait-to-fullscreen switch via button: you can see that the bottom side of the player is not fully expanded
made an enhancement Fix rotation when auto-rotate is disabled #4254 (comment)
fixed rotation via fullscreen button when a device in landscape in fullscreen with locked global orientation. So now in this case the device will rotate to portrait after press on fullscreen button (and back after another press). The fix is just one line, lol

~~final3.zip~~

More recent version below

MD77MD · 2020-09-27T01:56:02Z

tried final3 #4272 (comment) on android 4.4 and does solve those mentioned problems.

… on vertical video to portrait after clicking on fullscreen button

avently · 2020-09-27T03:54:34Z

Same as #4272 (comment) but with some changes:

made refactoring and included one suggestion to rotate the screen when in landscape & fullscreen on vertical video. So now the app will be rotated to portrait in this case after clicking on fullscreen button.

final4.zip

opusforlife2 · 2020-09-27T04:39:23Z

I'm reporting a small visual bug here which is present in the unified debug, since it probably has a small fix as well:

Play a playlist or some other queue, and open the queue from the main player. Swipe down in the middle. The queue will rapidly vibrate up and down.

TobiGr

Looks good to me!

Thank you for your ongoing efforts ❤️

app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java

avently · 2020-09-27T11:21:36Z

@opusforlife2

The queue will rapidly vibrate up and down.

Vibrate? What do you mean? Show a screenrecord, nothing unexpected happens for me

opusforlife2 · 2020-09-27T11:26:23Z

Give me a minute.

opusforlife2 · 2020-09-27T11:41:51Z

Wow. Just... wow. The video was large so I scaled it down using ffmpeg from 1080 to 720. Somehow the size went from 43 MiB to under 2 MiB. O.o

ScreenRecord.mp4.gz

TobiGr · 2020-09-27T11:51:43Z

I was able to reproduce this, too. only happens, when the status bar is hidden. fir some reason, on a pixel 3a XL simulator with Android 11, the status and navigation bar are always displayed (but without content) when playing a video:
Screenshot_1601207142

avently · 2020-09-27T12:06:50Z

@opusforlife2

ScreenRecord.mp4.gz

Thanks, reproduced.

fir some reason, on a pixel 3a XL simulator with Android 11, the status and navigation bar are always displayed (but without content) when playing a video

I use Pixel 3 emulator with Android 11 and no such problem. Are you sure you use the latest code or apk? Or do I need to do something special to reproduce?

TobiGr · 2020-09-27T12:17:43Z

I use Pixel 3 emulator with Android 11 and no such problem. Are you sure you use the latest code or apk? Or do I need to do something special to reproduce?

Never mind. Some noob tested the wrong version...

avently · 2020-09-27T12:54:30Z

@opusforlife2

ScreenRecord.mp4.gz

fixed
final5.zip

opusforlife2 · 2020-09-27T12:57:05Z

fixed
final5.zip

Confirmed!

TobiGr

Thank you, once again!

outdated

Small fixes of issues with old devices support, brightness, etc

883e4fc

opusforlife2 added this to In Progress in Unified Player regressions and bugs via automation Sep 11, 2020

avently mentioned this pull request Sep 12, 2020

Center videos correctly & fix padding for controls #4255

Closed

5 tasks

TobiGr added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels Sep 12, 2020

Android 11 initial support

011cc7d

avently mentioned this pull request Sep 13, 2020

Unified Player seekbar not appearing on Android 11 #4277

Closed

avently added 2 commits September 14, 2020 11:30

Android 11: transparent navigation and status bars

6d38615

Reimagined player positioning

150e156

Perfect shadow

a5312c1

avently mentioned this pull request Sep 26, 2020

Fix rotation when auto-rotate is disabled #4254

Closed

5 tasks

avently added 2 commits September 27, 2020 04:11

Fixed player's ZOOM mode for KitKat devices

d0fc9fd

avently mentioned this pull request Sep 27, 2020

(Unified player) Unexpected behaviour upon tapping fullscreen button after video ends #4322

Closed

Refactoring and made the player returning from landscape & fullscreen…

9a0c2c4

… on vertical video to portrait after clicking on fullscreen button

TobiGr reviewed Sep 27, 2020

View reviewed changes

app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java Show resolved Hide resolved

Merged 'dev' branch

609bf64

Disabled nested scrolling of queue

e53e5ca

TobiGr approved these changes Sep 27, 2020

View reviewed changes

TobiGr merged commit 541eb70 into TeamNewPipe:dev Sep 27, 2020

Unified Player regressions and bugs automation moved this from In Progress to Done Sep 27, 2020

This was referenced Sep 27, 2020

Release 0.20.0 #4332

Closed

Release 0.20.0 #4333

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Small fixes of issues with old devices support, brightness, etc #4272

Small fixes of issues with old devices support, brightness, etc #4272

avently commented Sep 11, 2020 •

edited

MD77MD commented Sep 11, 2020

opusforlife2 commented Sep 12, 2020

avently commented Sep 12, 2020

opusforlife2 commented Sep 12, 2020

avently commented Sep 12, 2020

MD77MD commented Sep 12, 2020

avently commented Sep 14, 2020

avently commented Sep 15, 2020 •

edited

opusforlife2 commented Sep 15, 2020

Stypox commented Sep 15, 2020

avently commented Sep 15, 2020

avently commented Sep 15, 2020

avently commented Sep 15, 2020

opusforlife2 commented Sep 15, 2020

Stypox commented Sep 15, 2020

avently commented Sep 15, 2020

MD77MD commented Sep 26, 2020 •

edited

avently commented Sep 26, 2020

MD77MD commented Sep 26, 2020 •

edited

avently commented Sep 26, 2020 •

edited

avently commented Sep 27, 2020 •

edited

MD77MD commented Sep 27, 2020 •

edited

avently commented Sep 27, 2020

opusforlife2 commented Sep 27, 2020

TobiGr left a comment

avently commented Sep 27, 2020

opusforlife2 commented Sep 27, 2020

opusforlife2 commented Sep 27, 2020

TobiGr commented Sep 27, 2020 •

edited

avently commented Sep 27, 2020

TobiGr commented Sep 27, 2020

avently commented Sep 27, 2020

opusforlife2 commented Sep 27, 2020

TobiGr left a comment

Small fixes of issues with old devices support, brightness, etc #4272

Small fixes of issues with old devices support, brightness, etc #4272

Conversation

avently commented Sep 11, 2020 • edited

What is it?

Description of the changes in your PR

Fixes the following issue(s)

Testing apk

Agreement

MD77MD commented Sep 11, 2020

opusforlife2 commented Sep 12, 2020

avently commented Sep 12, 2020

opusforlife2 commented Sep 12, 2020

avently commented Sep 12, 2020

MD77MD commented Sep 12, 2020

avently commented Sep 14, 2020

avently commented Sep 15, 2020 • edited

opusforlife2 commented Sep 15, 2020

Stypox commented Sep 15, 2020

avently commented Sep 15, 2020

avently commented Sep 15, 2020

avently commented Sep 15, 2020

opusforlife2 commented Sep 15, 2020

Stypox commented Sep 15, 2020

avently commented Sep 15, 2020

MD77MD commented Sep 26, 2020 • edited

avently commented Sep 26, 2020

MD77MD commented Sep 26, 2020 • edited

avently commented Sep 26, 2020 • edited

avently commented Sep 27, 2020 • edited

MD77MD commented Sep 27, 2020 • edited

avently commented Sep 27, 2020

opusforlife2 commented Sep 27, 2020

TobiGr left a comment

Choose a reason for hiding this comment

avently commented Sep 27, 2020

opusforlife2 commented Sep 27, 2020

opusforlife2 commented Sep 27, 2020

TobiGr commented Sep 27, 2020 • edited

avently commented Sep 27, 2020

TobiGr commented Sep 27, 2020

avently commented Sep 27, 2020

opusforlife2 commented Sep 27, 2020

TobiGr left a comment

Choose a reason for hiding this comment

avently commented Sep 11, 2020 •

edited

avently commented Sep 15, 2020 •

edited

MD77MD commented Sep 26, 2020 •

edited

MD77MD commented Sep 26, 2020 •

edited

avently commented Sep 26, 2020 •

edited

avently commented Sep 27, 2020 •

edited

MD77MD commented Sep 27, 2020 •

edited

TobiGr commented Sep 27, 2020 •

edited