Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.20.0 #4332

Closed
TobiGr opened this issue Sep 27, 2020 · 131 comments
Closed

Release 0.20.0 #4332

TobiGr opened this issue Sep 27, 2020 · 131 comments

Comments

@TobiGr
Copy link
Member

TobiGr commented Sep 27, 2020

Changelogs

App

New

Improved

Fixed

Development

Extractor

Improved

Fixed

  • Fix crash on empty YouTube comments

APK for testing

NewPipe_v0.20.0RC7.zip
Corresponding PR: #4333

@TobiGr TobiGr mentioned this issue Sep 27, 2020
4 tasks
@TobiGr TobiGr pinned this issue Sep 27, 2020
@Stypox

This comment has been minimized.

@avently

This comment has been minimized.

@opusforlife2

This comment has been minimized.

@Stypox

This comment has been minimized.

@opusforlife2

This comment has been minimized.

@avently

This comment has been minimized.

@Stypox

This comment has been minimized.

@XiangRongLin
Copy link
Collaborator

XiangRongLin commented Sep 27, 2020

It should not be possible to select the same buttons multiple times. Also for whatever reason the notification is blue.

@opusforlife2
Copy link
Collaborator

@XiangRongLin It takes the colour theme from the thumbnail. See the blue bar at the top of your video's thumbnail.

@XiangRongLin
Copy link
Collaborator

The option to not show the thumbnail on the lockscreen during background play is gone from the "player" section. Was it removed in purpose or what happened to it?

@opusforlife2
Copy link
Collaborator

This was discussed somewhere very recently. I think the idea was that the option was added because showing the thumbnail was buggy with the earlier notification, but now that we've shifted to MediaStyle notification, it's not needed anymore.

@terrytw

This comment has been minimized.

@opusforlife2

This comment has been minimized.

@test2a

This comment has been minimized.

@opusforlife2

This comment has been minimized.

@terrytw

This comment has been minimized.

@XiangRongLin
Copy link
Collaborator

XiangRongLin commented Sep 28, 2020

This was discussed somewhere very recently. I think the idea was that the option was added because showing the thumbnail was buggy with the earlier notification, but now that we've shifted to MediaStyle notification, it's not needed anymore.

@opusforlife2 How do i now not show the thumbnail on the lockscreen? I have the Android feature active to hide sensitive content, so it is just a blurry image. And i like my own wallpaper.

@XiangRongLin It takes the colour theme from the thumbnail. See the blue bar at the top of your video's thumbnail.

@opusforlife2 Is there an option to disable it? I really dislike having everything be darkmode and then newpipe sometimes displaying bright yellow/blue/white notifications.

@opusforlife2
Copy link
Collaborator

opusforlife2 commented Sep 28, 2020

Is there an option to disable it?

"Starting at Android O any notification that has a media session attached with setMediaSession(android.media.session.MediaSession.Token) will be colorized. You can opt-out of this behavior by using Notification.Builder#setColorized(boolean)."

https://developer.android.com/reference/android/app/Notification.MediaStyle

@XiangRongLin Maybe this can be added as an option in Notification settings?

How do i now not show the thumbnail on the lockscreen? I have the Android feature active to hide sensitive content, so it is just a blurry image. And i like my own wallpaper.

@XiangRongLin I suppose the option would have to be added back, or rewritten, maybe, since the related code has changed.

@opusforlife2

This comment has been minimized.

@terrytw

This comment has been minimized.

@opusforlife2
Copy link
Collaborator

opusforlife2 commented Sep 28, 2020

That's because there is no scope of the resolution changing there, and the player isn't changing either. The stream continues to play in the main player.

@test2a @terrytw For seamless switching (the stream doesn't pause at all) between players, follow #2863.

@snappyapple632

This comment has been minimized.

@opusforlife2

This comment has been minimized.

@snappyapple632

This comment has been minimized.

@MD77MD
Copy link

MD77MD commented Sep 28, 2020

I have noticed two bugs so far:

  1. the buffer bar does not update buffer position unless you interact with the player such as skipping (meaning even if the video is already 20s buffered ahead, the buffer bar will not show it unless you tab one of the player buttons such as skipping backwards) edit: please see buffer bar not showing buffer position #4343 @opusforlife2

  2. open a playlist in full-screen mode. while playing, tab the top-right button to show the queue. the bug: although the queue window is on top, you can still accidentally press the player ui buttons such as the video quality menu . I think the queue window should block player buttons until dismissed.

@MD77MD

This comment has been minimized.

@opusforlife2

This comment has been minimized.

@avently

This comment has been minimized.

@Stypox
Copy link
Member

Stypox commented Oct 2, 2020

settings (new not imported)

@eladkarako for me those settings import without issues, what's the problem?

@Stypox
Copy link
Member

Stypox commented Oct 2, 2020

I found an issue with the fullscreen button on tablets, I'm not sure if this is an emulator issue, but I don't think so.

  • Autorotation disabled, tablet in portrait
  • Open a video (VideoDetailFragment loads the layout layout, i.e. without -large-land)
  • Press fullscreen button
  • The rotation changes to landscape as expected, the VideoDetailFragment loads the layout-large-land layout as expected, but the player does not switch to fullscreen. In order to make it go fullscreen I had to press on the fullscreen button again.

Note that the behaviour obtained after pressing the fullscreen button is exactly the same as rotating the device, but on tablets rotating the device does not mean going into fullscreen mode. So the fullscreen button should in my opinion rotate the device and then go into fullscreen directly. Anyway, this is not release blocking, so unless @avently has a quick solution we can fix this later in 0.20.1 by ourselves.

@opusforlife2
Copy link
Collaborator

@N0TSUS It's just been fixed. Wait for the next RC.

@opusforlife2
Copy link
Collaborator

IRC. Link is on repo's Readme. 👍 You can join through the browser, your IRC client, or a Matrix account.

@TobiGr
Copy link
Member Author

TobiGr commented Oct 2, 2020

NewPipe_v0.20.0RC6.zip

@test2a
Copy link

test2a commented Oct 3, 2020

i am comparing 0.19.8 and the new rc6 and i find the page switcher icon missing at rest, ie, the user is NOT told about the next track, suggested videos

the two page switcher icons are very important because in absence of those, the user unless they know about swiping left will NOT switch left.
The icons do show up in the new version but i am having to first swipe down on the comments a bit and then it shows up. it should show up either at the top always like it was few updates ago or show up like 19.8, aka always
Screenshot_2020-10-03-09-40-04-2106767466
Screenshot_2020-10-03-09-40-20-0556460904

@avently
Copy link
Contributor

avently commented Oct 3, 2020

@test2a I made this because no one will need to see this two dots everytime. You only need to see them once to know that there are two pages. So they are useless when you already know about this

@TobiGr
Copy link
Member Author

TobiGr commented Oct 3, 2020

@test2a I did not notice that. Thank you!
@avently I agree with @test2a that the indicators should be there. The UI should be consistent and therefore display them always.

@avently
Copy link
Contributor

avently commented Oct 3, 2020

@TobiGr the way they worked before makes them appear in fullscreen. So when the player in fullscreen they are visible at the bottom of the screen.

@Miaourt
Copy link

Miaourt commented Oct 3, 2020

Sorry to hop in, maybe considere tiny "tabbed" design ? Like [comments/suggestions] ? Could be done in a thin way and would be really easier to understand at first
I was like "what why there is a carousel" after some time, and confused on when comments or suggestion where switching, for a long time 😅

@yufin1
Copy link

yufin1 commented Oct 3, 2020

1

Hello, the notification does not display the the current time in the video and how long the video is.
In #4332 (comment) is a screenshot with the timebar and the time numbers. I did not use this RC (and haven't found a download for this RC) since my first one which I downloaded was RC03 so I don't know if it was removed in later versions or if the commenter has different settings so that he get the timebar and numbers. I haven't found anything to change it though and so I am still using an older debug version which had the old notifications style. Is it a failure on my side for a wrong setting or were the timebar and numbers removed? I am on Android 9 with the RC6.

@Stypox
Copy link
Member

Stypox commented Oct 3, 2020

@yufin1 could you provide the exact steps to reproduce? Are you on Android 10?

@yufin1
Copy link

yufin1 commented Oct 3, 2020

@Stypox I am on android 9. Well it is just the normal notification if I start a video. So I just start playing a video and get the notification. I have used other RCs too and always got this notification without the timebar. But the timebar should be visible i.e. it wasn't removed?

@heberjeur
Copy link

I can't find subscriptions and bookmarked playlists, then, I tried to import my previous database,the tabs name are correct but their contents are missed
Screenshot_20201004-012351_One UI Home

@opusforlife2
Copy link
Collaborator

Hello, the notification does not display the the current time in the video and how long the video is.
I am on android 9.

@yufin1 That's not a bug. That's just a consequence of switching to MediaStyle notifications. The seekbar only appears on Android 10+ now.

@Stypox
Copy link
Member

Stypox commented Oct 4, 2020

I can't find subscriptions and bookmarked playlists, then, I tried to import my previous database,the tabs name are correct but their contents are missed

That's a known issue also in previous versions. If, after importing, you completely close the app and reopen it, everything should be fine.

@avently
Copy link
Contributor

avently commented Oct 4, 2020

I just noticed that notification doesn't contain current time and all time. Why? There is a place for a custom string inside notification. So you can pass 12:34 / 45:55 in it. Also you can pass place of a stream in a playlist too, like 12:34 / 45:55, 1/4. Can this be added?

@Stypox
Copy link
Member

Stypox commented Oct 4, 2020

@avently that would require updating the notification every second, which is not a good idea in my opinion, as it would increase battery consumption and hurt performance.

@TobiGr
Copy link
Member Author

TobiGr commented Oct 4, 2020

Last RC for this release: NewPipe_v0.20.0RC7.zip

  • updated translations
  • added the new languages to the app language selector
  • updated PrettyTime to resolve incorrect use of Russian plurals

@TobiGr TobiGr unpinned this issue Oct 4, 2020
@TobiGr TobiGr closed this as completed Oct 4, 2020
@avently
Copy link
Contributor

avently commented Oct 4, 2020

@Stypox from my point of view the cost is acceptable. I think the cost of cpu time should be measured before making a decision

@avently
Copy link
Contributor

avently commented Oct 4, 2020

One week of adapting the code to release. That's cool. Thank you everyone involved into the process. We did a great job!
I hope new releases will be compared to 0.20.0 and not with 0.19.8 😄

@avently
Copy link
Contributor

avently commented Oct 17, 2020

@opusforlife2 i'm a bit late but today I read a blog post about changes in this version. The post is so awesome! So detailed, with pictures and comparisons with previous version. Thank you for it.
Comments are great too. Basically we can see that most people like the update but haters can't stop hating. Nice experience

@opusforlife2
Copy link
Collaborator

@avently Thanks! Poolitzer and I worked on the blog post, and everyone contributed screenshots and short videos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests