Small fixes of issues with brightness, background playback, gestures #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested all 3. Confirmed working. 🥳 |
|
Tested brightness and it's perfect, thank you |
TobiGr
added
bug
|
I found one case brightness bug still happens:
Tell me if it wasn't clear enough, I can make a small video to show you |
|
Tested. Works as expected. Brightness changes only after lifting the finger, so accidental swipe will not cause any problems. 👍 |
|
works here too, thank you @avently ... you saved my eyes from melting away 😅 |
TobiGr
approved these changes
Sep 4, 2020
Stypox
approved these changes
Sep 5, 2020
|
I should not add this to the changelog, should I? |
|
Thank you @avently |
|
There is a list containing all unified player PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Just fixes for issues linked below + one thing that allows to play previous video from queue using previously viewed position (start playing queue, play next stream, tap back button, position will be restored).
Regarding this thing: https://github.com/TeamNewPipe/NewPipe/compare/dev...avently:small-fixes?expand=1#diff-5f76198512a7674ea2f085d5c554be97R187 it means that the app will be shut down only when video player is playing. Popup and background players will continue to play in background even if a user swiped the app away from recents. So the only way to kill the app is to use notification
closebutton or popup player's close button from the bottom of the screen.Fixes the following issue(s)
Testing apk
app-release.zip
Agreement