Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching orientation from landscape to portrait exits fullscreen #4936

Closed
4 tasks done
Atemu opened this issue Nov 20, 2020 · 4 comments
Closed
4 tasks done

Switching orientation from landscape to portrait exits fullscreen #4936

Atemu opened this issue Nov 20, 2020 · 4 comments
Labels
bug Issue is related to a bug

Comments

@Atemu
Copy link
Contributor

Atemu commented Nov 20, 2020

Checklist

Steps to reproduce the bug

  1. Open a video's info screen
  2. Start playing the video
  3. Make the video fullscreen
  4. Switch orientation from landscape to portrait
  5. Switch orientation back to landscape

Actual behaviour

The player exits fullscreen and we're now in the info screen in landscape.

Expected behavior

The player should stay in fullscreen or at least go fullscreen again when rotating back to landscape.

Screenshots/Screen recordings

Logs

Device info

  • Android version/Custom ROM version: Homebrewed LOS17.1
  • Device model: cheeseburger

(I set my system to 600DPI but the same happens at 480)

@Atemu Atemu added the bug Issue is related to a bug label Nov 20, 2020
Atemu added a commit to Atemu/NewPipe that referenced this issue Dec 1, 2020
Fixes TeamNewPipe#4936

Going from portrait to landscape doesn't toggle fullscreen in tablet mode, so
the reverse action shouldn't do it either.
@TobiGr TobiGr closed this as completed in c0ff1e8 Jan 14, 2021
@mof22
Copy link

mof22 commented Mar 25, 2021

PLEASE restore the full screen reproduction in portrait mode.
In previous versions I can view a landscape video in portrait mode with the subtitles outside the video frame.
Now subtitles occupy an important part of the video box and frequently obstruct a relevant part of the image.
This is very useful for those who need the assistance of the subtitles when we do not understand the language of the video.
In my case I do not understand English when I hear it, but I can read it with some fluidity.

@Atemu
Copy link
Contributor Author

Atemu commented Mar 26, 2021

@mof22 the fix for this issue should be in v0.20.10 (see commit above).

@mof22
Copy link

mof22 commented Mar 26, 2021

I am currently using version 0.20.11 and I could not play a landscape video with my device in a portrait position.

@Atemu
Copy link
Contributor Author

Atemu commented Mar 26, 2021

I was not able to reproduce this with vanilla NP v0.20.11, could you make a screencast of the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants