VideoDetailFragment: Don't exit fullscreen on rotation in tablet UI #4939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes TeamNewPipe#4936 Going from portrait to landscape doesn't toggle fullscreen in tablet mode, so the reverse action shouldn't do it either.
TobiGr
added
bug
If you're using uBO, have you allowed the required domain? |
|
I think there should be a toggle for this as there are others who prefer the original behavior |
|
I can't imagine a single scenario where you'd went the previous behavior (it was awful honestly) and I therefore don't think it's worth bloating the options for. |
|
We can merge this, but |
4 tasks
ghost
mentioned this pull request
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 20, 2021
…screen-on-rotation VideoDetailFragment: Don't exit fullscreen on rotation in tablet UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Going from portrait to landscape doesn't toggle fullscreen in tablet mode, so
the reverse action shouldn't do it either.
Fixes the following issue(s)
Relies on the following changes
APK testing
(Upload doesn't work, gets stuck :/)€: It was localCDN
app-debug.apk.zip
Due diligence