Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video open at the wrong timestamp (thousands place digit ignored) #7530

Closed
4 tasks done
lestofante opened this issue Dec 12, 2021 · 4 comments · Fixed by TeamNewPipe/NewPipeExtractor#775
Closed
4 tasks done

Video open at the wrong timestamp (thousands place digit ignored) #7530

lestofante opened this issue Dec 12, 2021 · 4 comments · Fixed by TeamNewPipe/NewPipeExtractor#775
Assignees
@triallax
Labels
bug Issue is related to a bug requires extractor change This issue requires a change to the extractor youtube Service, https://www.youtube.com/

Comments

@lestofante
Copy link

Checklist

Steps to reproduce the bug

100% reproducible

  1. Open link 'https://www.youtube.com/watch?v=y9aP4Ur-CXI&t=3939s'
  2. The video will open at timestamp ~15:40 instead of ~1:05:40

Device info

  • Android version/Custom ROM version: LineageOS 11
  • Device model: Redmi note 9s (EU)
@lestofante lestofante added the bug Issue is related to a bug label Dec 12, 2021
@SameenAhnaf
Copy link
Collaborator

This bug is awkward. I thought that the shared links were avoiding the value of hour. But this bug seems to be link specific. I can reproduce it with no other timestamp.

@lestofante lestofante changed the title Vieo open at the wrong timestamp Video open at the wrong timestamp Dec 12, 2021
@lestofante
Copy link
Author

did you try with big timestamp too? maybe is some kind of overflow, or some singularity in the calculation.
Also this is a VOD of a live stream, maybe there are some special handling for those?

@triallax triallax added the youtube Service, https://www.youtube.com/ label Dec 18, 2021
@triallax triallax self-assigned this Dec 18, 2021
@opusforlife2
Copy link
Collaborator

I encountered this too. Some quick math revealed that the 4th digit (the thousands place) is ignored. If t=1234s, you're taken to t=234s instead.

@opusforlife2 opusforlife2 changed the title Video open at the wrong timestamp Video open at the wrong timestamp (thousands place digit ignored) Dec 25, 2021
triallax added a commit to triallax/NewPipeExtractor that referenced this issue Jan 10, 2022
@triallax
[YouTube] parse timestamps with >3 digits correctly
0bdc53d 
Fixes TeamNewPipe/NewPipe#7530, check the
issue for details.
triallax added a commit to triallax/NewPipeExtractor that referenced this issue Jan 10, 2022
@triallax
[YouTube] parse timestamps with >3 digits correctly
6f6428c 
Fixes TeamNewPipe/NewPipe#7530, check the
issue for details.
triallax added a commit to triallax/NewPipeExtractor that referenced this issue Jan 10, 2022
@triallax
[YouTube] parse timestamps with >3 digits correctly
e5fd402 
Fixes TeamNewPipe/NewPipe#7530; check the
issue for details.
triallax added a commit to triallax/NewPipeExtractor that referenced this issue Jan 10, 2022
@triallax
[YouTube] parse timestamps with >3 digits correctly
d3a5635 
Fixes TeamNewPipe/NewPipe#7530; check the
issue for details.
@triallax triallax mentioned this issue Jan 10, 2022
Merged
3 tasks
@triallax
Copy link
Contributor

Sorry for the spam, I was force-pushing more than I should have. nervous laughter

Can you try the APK in the description of TeamNewPipe/NewPipeExtractor#775?

@triallax triallax added the requires extractor change This issue requires a change to the extractor label Jan 10, 2022
XiangRongLin pushed a commit to TeamNewPipe/NewPipeExtractor that referenced this issue Jan 12, 2022
@triallax
[YouTube] parse timestamps with >3 digits correctly (#775)
65df39b 
* [YouTube] parse timestamps with >3 digits correctly

Fixes TeamNewPipe/NewPipe#7530; check the
issue for details.

* Remove outdated comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@triallax triallax

Labels
bug Issue is related to a bug requires extractor change This issue requires a change to the extractor youtube Service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[YouTube] parse timestamps with >3 digits correctly triallax/NewPipeExtractor
4 participants
@lestofante @triallax @opusforlife2 @SameenAhnaf