-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.21.15 Old regression returned: slow playback on LineageOS #7599
Comments
connect to your OnePlus One with adb. |
Here it is: Output of greprop | grep build
|
Build.DISPLAY.contains("lineage") should do it then. Thanks |
Am I understanding this correctly Note: There is a issue open in the LineageOS issuetracker: https://gitlab.com/LineageOS/issues/android/-/issues/3475 Btw I think we should either close this issue and keep the discussion in #6207 or vice versa. |
Correct.
Thus, even though the symptom is identical to the video demo in #6207 (comment), my guess for the reason was wrong.
The issue #6207 was solved and kept open (#6207 (comment)) to track what happend to this issue from the lineageOS side. |
Hi, Newpipe versions
Device info
|
there is nothing that can be done at the moment @fdutheil Your device is not maintained anymore and won't get LinegeOS 18.1. The fix could be applied to LineageOS 16.0 if you are on a LineageOS build that is supported by someone you can ask him to check the solution of this issue: https://gitlab.com/LineageOS/issues/android/-/issues/3475 If your LineageOS 16.0 is also not maintained anymore you can't do anything. For me this issue is a won't fix. Affected devices with Lineage OS 18.1 can update while workaround for older devices is not applicable. The only "solution" would be to downgrade ExoPlayer which won't happen. Maybe more recent versions of ExoPlayer do feature support to change the media extractor behaviour, we need to check that. At the current version that is used in NewPipe we don't have that flexibility as far as I know. So please use 720p60 for the time being. |
Closing as resolved, then. The solution is to update to LineageOS 18.1. Edit:
The issue could be reopened if that ever happens. |
Wanted to confirm the fix. |
looks like there is a solution to restore the behaviour of earlier ExoPlayer releases without downgrading ExoPlayer. We could apply this to only LineageOS devces that do not have version 18.1. google/ExoPlayer#9565 (comment) Thanks to @TiA4f8R for pointing this out. @fdutheil |
Sorry, but I'm in favor of closing this issue and don't fixing it any further because
|
@Redirion : Awesome, I tested the debug APK and it's smooth @1080p60 @litetex : if a user or a device deserves a fix for an issue is not relevant (beyond being a non technical matter). Ratio effort/gain is the only relevant metrics to appreciate this, as you said. As for "who is affected", this is pretty much any current or future device with decoders not "correctly" specified (to ExoPlayer's eyes), if I understand correctly. As a side note, VLC is dealing with buggy or not correctly presented hardware decoders too, with an elegant solution: if I simplify, VLC hardware decoding setting presented to the user has 3 states:
|
thanks for the feedback @fdutheil @litetex as this seems to be a per device basis fixing thing we could take the opportunity to add two new video options with a new category:
Both are completely different. While the first is about a device incorrectly reporting it supports offloading (aka hardware decoding) the other point here is that the device incorrectly claims to support less than it could. For media tunneling you already suggested we should made it an option instead of adding all devices manually as soon as someone reports an issue: |
Consider the following case (click to expand)
|
Is it still an issue when using this debug build from the |
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further. |
As the repo was locked, nobody could reply and the issue was auto-closed... quite as expected. Hello @AudricV. |
@fdutheil You can see if the issue is fixed using the debug/release APK of the 0.24.0 release candidate. |
@AudricV : issue still present in the debug/release APK of the 0.24.0 release candidate, 1080p60 videos are still choppy with NewPipe internal player. |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
@FrostKiwi @fdutheil Could you try the APK of #8875, enable the |
Hi @AudricV : tested, playback is smooth again at 1080p60 with internal player 👍 |
@fdutheil Could you test the debug APK of #9847 and see if the issue persists? The newest ExoPlayer version made new changes about how codecs are selected (look at the changelog of ExoPlayer linked in the PR for more details), so this may have changed the codec ExoPlayer choose on your device (and so the setting in #8875 may be not needed). Thanks in advance. |
Thanks for the feedback! I am closing issue due to your comment, and I am also removing the addition of the old codec selection setting in #8875, as this issue only affects a few devices and is due to bad configuration of your ROM and not to an ExoPlayer bug. |
As previously with v0.21.2, updating to v0.21.15 regressed the playback performance to a 10fps slideshow on the OnePlus One with 1080p60 footage.
Previously reported and discussed indepth here with screen recordings and so on: #6207
Thus it is most likely in connection to ExoPlayer not properly detecting the hardware decoding features of the OnePlus One and thus falling back to a software decoded slideshow on 1080p60 footage.
I downgraded to v0.21.14 and the issue is gone.
Checklist
Device info
The text was updated successfully, but these errors were encountered: