Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to ExoPlayer 2.18.3 #9847

Merged
merged 1 commit into from Feb 26, 2023
Merged

Update to ExoPlayer 2.18.3 #9847

merged 1 commit into from Feb 26, 2023

Conversation

Redirion
Copy link
Member

@Redirion Redirion commented Feb 23, 2023 •
edited by AudricV

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Same as #9553 but this time with ExoPlayer 2.18.3 (changelog)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AudricV AudricV added player Issues related to any player (main, popup and background) codequality Improvements to the codebase to improve the code quality labels Feb 25, 2023
@AudricV AudricV mentioned this pull request Feb 25, 2023
Closed
4 tasks
@Redirion Redirion marked this pull request as ready for review February 26, 2023 07:56
Stypox
Stypox approved these changes Feb 26, 2023
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce the issue on my phone anymore. Thank you for the patience. Let's merge this again, and see if any user faces any issue.

@Stypox Stypox merged commit 73aebc1 into TeamNewPipe:dev Feb 26, 2023
@Redirion Redirion deleted the exo183 branch February 27, 2023 22:26
@Stypox Stypox mentioned this pull request Mar 1, 2023
Closed
3 tasks
@pihug12
Copy link

pihug12 commented Mar 5, 2023

ExoPlayer 2.18.4 is out too with the "Fix NullPointerException when calling ExoPlayer.isTunnelingEnabled" : https://github.com/google/ExoPlayer/blob/release-v2/RELEASENOTES.md#2184-2023-03-02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality player Issues related to any player (main, popup and background)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Redirion @pihug12 @Stypox @AudricV