Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Kotlin to 1.8.20 and AndroidX Core to 1.10 and switch to AndroidX's PendingIntentCompat #10021

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Apr 13, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Replace the custom PendingIntentCompat class with AndroidX's one.
  • Update Kotlin to 1.8.20 to fix issues with the build.

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TobiGr TobiGr added the codequality Improvements to the codebase to improve the code quality label Apr 13, 2023
@Stypox
Copy link
Member

Stypox commented Apr 14, 2023

Why did we introduce our own PendingIntentCompat instead of using the library directly? Also, can you link to the PR(s) that introduced it, to get an idea of the context?

@Isira-Seneviratne
Copy link
Member Author

Isira-Seneviratne commented Apr 14, 2023

Why did we introduce our own PendingIntentCompat instead of using the library directly? Also, can you link to the PR(s) that introduced it, to get an idea of the context?

I added it in this PR as part of the changeset for targeting Android 13 a few months ago. AndroidX Core 1.10, which introduced its own PendingIntentCompat class, was released about a week ago.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By looking at the source code it should work almost the same as our code. I tested a bit and did not encounter issues. Thanks!

@Stypox Stypox merged commit ba3afd1 into TeamNewPipe:dev Apr 14, 2023
@AudricV AudricV changed the title Switch to AndroidX's PendingIntentCompat. Switch to AndroidX's PendingIntentCompat and update Kotlin to 1.8.20 Apr 14, 2023
@AudricV AudricV changed the title Switch to AndroidX's PendingIntentCompat and update Kotlin to 1.8.20 Update to Kotlin to 1.8.20 and AndroidX Core to 1.10 and switch to AndroidX's PendingIntentCompat Apr 14, 2023
@Isira-Seneviratne Isira-Seneviratne deleted the PendingIntentCompat branch April 18, 2023 10:05
This was referenced Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants