-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leaks and add documentation #10394
Conversation
8654788
to
61dc1b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, your changes look good to me.
Here are some improvements on the Javadocs you added which would make them better.
61dc1b4
to
35de7c1
Compare
Add documentation to BaseFragment.initViews(View, Bundle) and BaseFragment.initListeners()
35de7c1
to
8f83e39
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I sometimes get an undeliverable Exception thrown with this APK. Not sure if this is related:
It's unrelated, it's a problem in the extractor
What is it?
Description of the changes in your PR
Fixed three memory leaks and added documentation to
BaseFragment.initViews()
andBaseFragment.initListeners()
.The leaks were detected in the channel tabs PR APK, but also occur to the current dev version.
LeakCanary warnings for each leak:
BaseFragment
MainFragment.binding
SubscriptionFragment
Note
I sometimes get an undeliverable Exception thrown with this APK. Not sure if this is related:
Details
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence