Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update miscellaneous libraries #10530

Merged
merged 7 commits into from Dec 23, 2023
Merged

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Nov 1, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@TacoTheDank TacoTheDank force-pushed the bumpMiscLibraries branch 2 times, most recently from 9db4049 to 96a0e13 Compare November 1, 2023 02:39
Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In a similar way to jsoup with its README.md and CHANGES files, RxJava is now adding LICENSE and COPYRIGHT files into its JARs: see https://github.com/ReactiveX/RxJava/blob/e6f152df7e2f2061435ee8ac3f6ed82cf34e3c58/build.gradle#L90-L94. Could you remove them?

@TacoTheDank
Copy link
Member Author

In a similar way to jsoup with its README.md and CHANGES files, RxJava is now adding LICENSE and COPYRIGHT files into its JARs: see https://github.com/ReactiveX/RxJava/blob/e6f152df7e2f2061435ee8ac3f6ed82cf34e3c58/build.gradle#L90-L94. Could you remove them?

I checked the built artifact, and it seems that only the COPYRIGHT file was there. LICENSE wasn't in the META-INF.

@AudricV AudricV added the dependency Issues and PRs related to dependencies label Nov 16, 2023
Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good, thank you!

Have any dependency updates been released in the meantime? If so, could you apply them?

app/build.gradle Show resolved Hide resolved
@TacoTheDank
Copy link
Member Author

Have any dependency updates been released in the meantime? If so, could you apply them?

Done. I didn't do Kotlin though, I want to update Ktlint first in another PR.

Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Stypox Stypox force-pushed the bumpMiscLibraries branch 3 times, most recently from a39b591 to 8eb5f1d Compare December 23, 2023 10:35
@Stypox
Copy link
Member

Stypox commented Dec 23, 2023

I pushed more updates:

  • androidx.fragment:fragment-ktx 1.6.1 -> 1.6.2 (changelog)
  • androidx.media:media 1.6.0 -> 1.7.0 (changelog)
  • com.google.android.material:material 1.9.0 -> 1.11.0 (changelog)
  • Android Gradle Plugin 8.1.4 -> 8.2.0 (changelog)
  • Gradle 8.1.1 -> 8.2.0

@Stypox Stypox merged commit 2b4357f into TeamNewPipe:dev Dec 23, 2023
3 of 7 checks passed
Copy link

sonarcloud bot commented Dec 23, 2023

@TacoTheDank TacoTheDank deleted the bumpMiscLibraries branch January 17, 2024 22:16
@Stypox Stypox mentioned this pull request Apr 1, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Issues and PRs related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants