Initial setup for Settings page redesign with debug settings #10849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new settings option to enable the settings page redesign. - This option allows us to integrate and test the new settings page gradually, minimizing disruptions to the current behavior. - Reused the rest of the debug menu to reflect in the new settings page. - Verified the functionality of all debug settings. Next plan: - Create PRs to gradually add all the subsections as detailed in TeamNewPipe#9587. Note: - This PR prepares for upcoming updates by setting up the necessary changes for follow-up PRs.
5 tasks
|
5 tasks
5 tasks
acrodemocide
reviewed
Mar 9, 2024
There was a problem hiding this comment.
I only have one comment I left here that is pretty minor, and it may be a non issue based on how this project is maintained. I still need to test this to determine if it works properly. Then after I determine it works properly from testing, I'll approve. (If it breaks, I'll leave a comment here indicating what isn't working.)
app/src/main/java/org/schabi/newpipe/settings/SettingsResourceRegistry.java
Show resolved
Hide resolved
5 tasks
|
As explained in #10849 (comment), let's close this PR if it's going to be replaced by the Jetpack Compose one. We can always reopen it in case ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Initial setup for Settings page redesign with debug settings
Next plan:
Note:
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence