Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate comment fragments to Jetpack Compose #11060

Open
wants to merge 20 commits into
base: refactor
Choose a base branch
from

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented May 12, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update the Compose dependencies to their latest versions.
  • Add the Compose library for Coil to handle image loading.
  • Add the LazyColumnScrollbar library to display scrollbars in Compose.
  • Migrate the comments to use Jetpack Compose and replace the comment replies fragment with a bottom sheet dialog.

Before/After Screenshots/Screen Record

  • Before:

Screenshot_20240621-161715
Comments

Screenshot_20240621-183000
Comment replies

  • After:

Screenshot_20240621-161728
Comments

Screenshot_20240623-110556
Screenshot_20240623-110604
Comment replies

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added size/medium PRs with less than 250 changed lines size/large PRs with less than 750 changed lines and removed size/medium PRs with less than 250 changed lines labels May 12, 2024
Copy link

sonarcloud bot commented May 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Isira-Seneviratne Isira-Seneviratne changed the base branch from dev to refactor May 17, 2024 03:55
@Isira-Seneviratne Isira-Seneviratne force-pushed the Comments-Compose branch 2 times, most recently from c77ea74 to c106fb0 Compare May 17, 2024 04:02
@Isira-Seneviratne Isira-Seneviratne marked this pull request as ready for review May 17, 2024 04:48
@github-actions github-actions bot added size/giant PRs with more than 750 changed lines and removed size/large PRs with less than 750 changed lines labels Jun 18, 2024
@Isira-Seneviratne Isira-Seneviratne force-pushed the Comments-Compose branch 3 times, most recently from 4dcc153 to 5d88f37 Compare June 19, 2024 07:31
@Isira-Seneviratne Isira-Seneviratne changed the title Convert comment replies views to Jetpack Compose Migrate comment fragments to Jetpack Compose Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/giant PRs with more than 750 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Jetpack Compose for NewPipe UI
1 participant