Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate comment fragments to Jetpack Compose #11060

Open
wants to merge 49 commits into
base: refactor
Choose a base branch
from
Open

Migrate comment fragments to Jetpack Compose #11060

wants to merge 49 commits into from

Commits on Jul 3, 2024

  1. Load notification icons using Coil

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    92a7f22 View commit details
    Browse the repository at this point in the history

  2. Migrate to Coil from Picasso

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    844b4ed View commit details
    Browse the repository at this point in the history

  3. Clean up Picasso leftovers

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e6302cc View commit details
    Browse the repository at this point in the history

  4. Enable RGB-565 for low-end devices

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    4d3b4a7 View commit details
    Browse the repository at this point in the history

  5. Added Coil helper method

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f74402b View commit details
    Browse the repository at this point in the history

  6. Add annotation

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e3b7bf4 View commit details
    Browse the repository at this point in the history

  7. Simplify newImageLoader implementation

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    8aa2590 View commit details
    Browse the repository at this point in the history

  8. Use Coil's default disk and memory cache config

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    71361de View commit details
    Browse the repository at this point in the history

  9. Enable crossfade animation

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    39d0691 View commit details
    Browse the repository at this point in the history

  10. Correct method name

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    c4ada7f View commit details
    Browse the repository at this point in the history

  11. Fix thumbnail not being displayed in media notification

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    348a79f View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Update Coil

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    da83646 View commit details
    Browse the repository at this point in the history

  2. Addressed code review comments

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    4ec7532 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Convert comment replies views to Jetpack Compose

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    08f0338 View commit details
    Browse the repository at this point in the history

  2. Rename .java to .kt

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c429deb View commit details
    Browse the repository at this point in the history

  3. Use reply header composable in fragment

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e193265 View commit details
    Browse the repository at this point in the history

  4. Added like count

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    fc8a748 View commit details
    Browse the repository at this point in the history

  5. Added missing comment features, fixed theming

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b302c1b View commit details
    Browse the repository at this point in the history

  6. Add comment ellipsis

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b14da3a View commit details
    Browse the repository at this point in the history

  7. Update replies fragment to use the comment composable as well

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    65fce6e View commit details
    Browse the repository at this point in the history

  8. Improve previews, display date of comment

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f056edd View commit details
    Browse the repository at this point in the history

  9. Fixed some comment issues

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e75eb2d View commit details
    Browse the repository at this point in the history

  10. Use AnnotatedString to handle HTML parsing

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c29fa70 View commit details
    Browse the repository at this point in the history

  11. Add replies button

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e71fc38 View commit details
    Browse the repository at this point in the history

  12. Set view strategy

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b6a0f5d View commit details
    Browse the repository at this point in the history

  13. Fixed like count display

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    552ea50 View commit details
    Browse the repository at this point in the history

  14. Fixed fragment title

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    cf3fb0b View commit details
    Browse the repository at this point in the history

  15. Rename .java to .kt

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f27273e View commit details
    Browse the repository at this point in the history

  16. Migrate comments fragment to Jetpack Compose

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    03bc4e2 View commit details
    Browse the repository at this point in the history

  17. Added scrollbar to comment section

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ff88184 View commit details
    Browse the repository at this point in the history

  18. Replace CommentRepliesFragment with bottom sheet composable, improve … 

    …previews
    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    754bf45 View commit details
    Browse the repository at this point in the history

  19. Replace Spacers with the horizontalArrangement parameter

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    cc6f1ff View commit details
    Browse the repository at this point in the history

  20. Handle no comments and comments disabled scenarios

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8d4c608 View commit details
    Browse the repository at this point in the history

  21. Rm redundant Surface

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e87a2e0 View commit details
    Browse the repository at this point in the history

  22. Improve code organization

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    219da28 View commit details
    Browse the repository at this point in the history

  23. Cache paging data using the cachedIn() extension

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    975a341 View commit details
    Browse the repository at this point in the history

  24. Add comment view model

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    94ef79c View commit details
    Browse the repository at this point in the history

  25. Rm extra padding in header

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    21b22d3 View commit details
    Browse the repository at this point in the history

  26. Replace padding modifier with verticalArrangement in comment header

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    4b13e30 View commit details
    Browse the repository at this point in the history

  27. Added loading indicator

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1c503ce View commit details
    Browse the repository at this point in the history

  28. Rm unused method

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ddbfcf8 View commit details
    Browse the repository at this point in the history

  29. Improve comment loading smoothness

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3c55d95 View commit details
    Browse the repository at this point in the history

  30. Animate comment expand/collapse

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f438ba4 View commit details
    Browse the repository at this point in the history

  31. Make parsed links clickable, visible

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b83f643 View commit details
    Browse the repository at this point in the history

  32. Fix alignment of comment message

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    0d9c4aa View commit details
    Browse the repository at this point in the history

  33. Fix some modifiers

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f285bc0 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Added DescriptionText composable

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f1591ab View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Improved component organisation

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    b2748cc View commit details
    Browse the repository at this point in the history

  2. Update Kotlin to 2.0, update dependencies and fix issues

    @Isira-Seneviratne
    Isira-Seneviratne committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    10dd571 View commit details
    Browse the repository at this point in the history