Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Accessebility for blind people #2655

Merged
merged 6 commits into from
Oct 1, 2019
Merged

Improve Accessebility for blind people #2655

merged 6 commits into from
Oct 1, 2019

Conversation

theScrabi
Copy link
Member

I have worked with @fcnjd on improving the accessibility of NewPipe for blind people. I learned that there are still a lot of pit holes, however we already took on some very annoying things. Mostly they consisted of wrong or missing content descriptions.

Improvements:

  • change video preveiw thumbnail text to "play video"
  • add tab content description in main page
  • add content description and service announcement for the toggle service button

@opusforlife2
Copy link
Collaborator

Is there currently a way to play audio only by default? Something like a toggle that would remove all video options so that only audio ones remain.

@theScrabi
Copy link
Member Author

theScrabi commented Sep 22, 2019

@fcnjd told me it was not that importand as there is already an audio only function, however one could use the video function to still be able to show videos to others.

So in some sens he ment there is no need for an additional audio only mode.

@Gymcap
Copy link

Gymcap commented Sep 23, 2019

I think if the background player view was given a bit more attention and brought forward a bit, it would meet a lot of these "audio only" needs.

@theScrabi
Copy link
Member Author

Yea you are right. This should definitely be done soon.

@theScrabi theScrabi added the feature request Issue is related to a feature in the app label Sep 24, 2019
@Stypox
Copy link
Member

Stypox commented Oct 1, 2019

@TobiGr this can be merged, too ;-)

@TobiGr TobiGr merged commit b4b24a4 into dev Oct 1, 2019
@TobiGr TobiGr deleted the accessebility branch October 1, 2019 19:25
This was referenced Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants