Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle and introduce Kotlin to NewPipe #2714

Merged
merged 1 commit into from
Nov 3, 2019

Conversation

mauriciocolli
Copy link
Contributor

Update Gradle and introduce Kotlin

I think it's time we introduce Kotlin to NewPipe as I consider it very nice to use. The main reasons/opinions as to why I think it'd be good to the project:

  • I want to learn more about it, so why not have more contact with it
  • Want to learn something new
  • Relative ease to migrate and interact with Java code
  • Enjoyable coding overall

If you think this is not a good addition for NewPipe, please post your thoughts below.

@Koitharu
Copy link
Contributor

I think, we do not need Kotlin in this project, aren`t?

@TobiGr
Copy link
Member

TobiGr commented Oct 31, 2019

IMO Kotlin simplifies code a lot: easy null checks, less unnecessary brackets, etc.
@theScrabi We had the discussion somewhere before. I'd approve Kotlin support. What's you opinion?

Apart from that, #2309 is written in Kotlin and I'd like to get this merged asap.

@Stypox
Copy link
Member

Stypox commented Oct 31, 2019

I am in favour of the introduction of Kotlin, since it is faster to program in and the transition from Java is smooth

TobiGr
TobiGr previously approved these changes Oct 31, 2019
@TobiGr TobiGr merged commit 1a9b3c9 into TeamNewPipe:dev Nov 3, 2019
This was referenced Dec 12, 2019
@mauriciocolli mauriciocolli deleted the introduce-kotlin branch March 7, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants