Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ExoPlayer to 2.10.6 and OkHttp to 3.12.6 #2736

Merged
merged 1 commit into from
Oct 20, 2019
Merged

Bump ExoPlayer to 2.10.6 and OkHttp to 3.12.6 #2736

merged 1 commit into from
Oct 20, 2019

Conversation

Redirion
Copy link
Member

Little dependency update.
ExoPlayer Changelog: https://github.com/google/ExoPlayer/blob/release-v2/RELEASENOTES.md
OkHttp Changelog: https://square.github.io/okhttp/changelog_3x/#version-3126

@opusforlife2 opusforlife2 mentioned this pull request Oct 19, 2019
@Pentaphon
Copy link

Pentaphon commented Oct 19, 2019

That audio focus bugfix on Exoplayer is probably worth merging before the next release.

@Redirion
Copy link
Member Author

It looks like this is more a change for ExoPlayer's own audio focus handling, which NewPipe doesn't use.
Speaking of that I think it might be considerable to make use of ExoPlayer's AudioFocusManager instead of NewPipes own AudioReactor. The AudioReactor might also be a source of "SimpleExoPlayer is accessed from the wrong thread" warnings.

@TobiGr TobiGr merged commit 0b7e1bc into TeamNewPipe:dev Oct 20, 2019
@TobiGr TobiGr mentioned this pull request Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants