Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Open website" button to WebView in license fragment #6314

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Add "Open website" button to WebView in license fragment #6314

merged 3 commits into from
Jun 8, 2021

Conversation

Peyman-hme
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR adds "Open website" button to alert dialog and removed popup menu that is opened when we long-pressed on one of the licenses.

  • license
  • about

Screenshot:
OpenWebsiteButton

Fixes the following issue(s)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@opusforlife2 opusforlife2 changed the title Add "Open website" button to webView in license fragment, issue #6296 Add "Open website" button to webView in license fragment May 16, 2021
@AudricV AudricV added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels May 16, 2021
@AudricV AudricV changed the title Add "Open website" button to webView in license fragment Add "Open website" button to WebView in license fragment May 16, 2021
@skyGtm
Copy link

skyGtm commented May 17, 2021

Few suggestions:

  1. The buttons looks congested so I think, setting OPEN WEBSITE as neutral button and OK as positive button will look good.
    Capture

  2. renaming OK string to DISMISS would make more sense.(I think)

@Peyman-hme
Copy link
Contributor Author

@skyGtm Thanks for your feedbacks, done.
DismissButton

AudricV
AudricV previously approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, even if I am not a developer and not familiar with Kotlin. So you will have to wait until a real Android developer of team review your PR in order to get it merged.

Stypox
Stypox previously approved these changes Jun 8, 2021
View reviewed changes
@Stypox Stypox dismissed stale reviews from AudricV and themself via 6fc0d8f June 8, 2021 09:30
@Stypox Stypox force-pushed the Add-Open-website-button-to-webview-in-license-fragment-issue-#6296 branch from 7199ea3 to 6fc0d8f Compare June 8, 2021 09:30
@Stypox Stypox merged commit 63cff25 into TeamNewPipe:dev Jun 8, 2021
@Stypox
Copy link
Member

Stypox commented Jun 8, 2021

Thank you @Peyman-hme :-)

This was referenced Jun 26, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

@AudricV AudricV AudricV left review comments

Assignees
No one assigned
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestions for Licenses page
4 participants
@Peyman-hme @skyGtm @Stypox @AudricV