Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Period Transition #7408

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Conversation

Redirion
Copy link
Member

@Redirion Redirion commented Nov 14, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

I missread the ExoPlayer 2.14.0 changelog
Report information about the old and the new playback positions to Listener.onPositionDiscontinuity. Add DISCONTINUITY_REASON_SKIP and DISCONTINUITY_REASON_REMOVE as discontinuity reasons, and rename DISCONTINUITY_REASON_PERIOD_TRANSITION to DISCONTINUITY_REASON_AUTO_TRANSITION. Remove DISCONTINUITY_REASON_AD_INSERTION, for which DISCONTINUITY_REASON_AUTO_TRANSITION is used instead

particularly as REASON_AD_INSERTION was replaced by REASON_AUTO_TRANSITION I replaced this in our code. However as PERIOD-TRANSITION was changed to AUTO_TRANSITION we lost the previous behaviour. Stupid me.
This commit fixes the ExoPlayer 2.14.2 PR #7005

I am a bit unsure if DISCONTINUITY_REASON_REMOVE should be at the same position, but according to the javadoc it should be, so I would leave it there unless anyone has objections.
I have checked the ExoPlayer Sourcecode, for me it looks like this is okay there.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@TobiGr TobiGr added the player Issues related to any player (main, popup and background) label Nov 14, 2021
@AudricV AudricV added the bug Issue is related to a bug label Nov 14, 2021
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Scrolled a bit inside the player, tested background and popup player.
Seems as everything is working as expected.

@Redirion Redirion merged commit 72dfe97 into TeamNewPipe:dev Nov 15, 2021
@Redirion Redirion deleted the fixedautotransition2 branch November 15, 2021 18:59
This was referenced Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants