Refactor removeWatchedStreams() in LocalPlaylistFragment. #8706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triallax
added
the
codequality
Stypox
reviewed
Aug 3, 2022
There was a problem hiding this comment.
The code works as it did before, thank you for the improvement. While you are at it you could also add a commit to fix the persisting behavior of the "remove watched" action. What I mean is, currently if you trigger "remove watched" in a playlist and then, while keeping that playlist open, watch one of its videos (e.g. using "mark as watched"), then the video is instantly removed from the playlist (even though "remove watched" was not clicked one more time). I think this can be fixed by taking only the first item of the getPlaylistStreams Flowable.
app/src/main/java/org/schabi/newpipe/local/playlist/LocalPlaylistFragment.java
Outdated
Show resolved
Hide resolved
Isira-Seneviratne
force-pushed
the
Improve_LocalPlaylistFragment
branch
2 times, most recently
from
f9017c8
to
9aa37e1
Compare
Isira-Seneviratne
force-pushed
the
Improve_LocalPlaylistFragment
branch
from
9aa37e1
to
6399e39
Compare
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Nov 4, 2022
Merged
This was referenced Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
removeWatchedStreamsmethod inLocalPlaylistFragment.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence