Fix wrong thumbnail in notification on Android 13

[Stypox]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR fixes yet another issue about the notification thumbnail not changing when going to the previous or next item in the player queue (see #8890 (comment)).

What I think the problem was (though this might need more investigation) is this:

1. when tapping on "next", NewPipe's queue implementation would go to the next item
2. then the ExoPlayer's internal media item queue gets synchronized, by telling the player to go to the next item
3. the player internally switches to the next item, and it starts loading its stream details to be able to play it, also updating the item index in the media session (a component that the system can read to get info)
4. the player switches state to onBuffering, which triggers a notification update for NewPipe
5. notification updates are implemented not based on the selected queue item (currentItem) but rather on the StreamInfo (currentMetadata) and the currentThumbnail stored in the player. That StreamInfo, though, still belongs to the previous item in the queue, since stream details have not finished loading yet. This causes the wrong title, uploader and thumbnail to be temporarily set in the notification.
6. the stream details finally load, they are set in the player and the notification is updated again, this time with the correct information
7. title and uploader are correctly updated in the notification, but the thumbnail is not. This happens probably because the system associated the thumbnail of the previous item to the index of the next, and then tries to avoid reloading the thumbnail again to save cpu, assuming the first set thumbnail was the correct one. Triggering notification updates in other ways (e.g. play-pause) does not make a difference.

So in the PR that will merge NotificationUtil and NotificationPlayerUi, the notification, the player and the media session should be switched to using data not about the player StreamInfo, but rather the actual current play queue item (except for the thumbnail, for which we need the high-res one from the fully-loaded stream details). Though it might not be this simple.

This PR fixes the problem by detecting when the queue item changes and then setting currentThumbnail to null. This happens in-between points 1 and 2 above, i.e. before the exoPlayer internal queue is synced and before the notification update is triggered.

The commits strictly necessary to solve the issue are the first two, though the other two are also important in my opinion.

Fixes the following issue(s)

• Release v0.24.0 (please TEST!) #8890 (comment)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[Stypox]

@karyogamy could you explain why the !isPlaying() is needed on this line? You initially introduced it in 1d136c6 (#810), then accidentally removed it in 4e459b3 and readded it in b81eb35 (#8020).

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

[opusforlife2]

Has the reddit reporter been asked to test this?

[AudricV]

Yes, and it was claimed to be fixed by the user but their comments have been now deleted.