Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize useSimpleSummaryProvider attribute #9011

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Utilize useSimpleSummaryProvider attribute instead of using android:summary="%s"

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@AudricV AudricV added the codequality Improvements to the codebase to improve the code quality label Sep 23, 2022
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

However, the sonarlint job failed. Re-running the other jobs made them fail, too. Looks like the extractor version cannot be found... I guess this is a temporary outage. We'll need to re-run the tests later again. Can be merged once the tests succeed.

@AudricV
Copy link
Member

AudricV commented Oct 9, 2022

Rebasing the PR should be also good, as when using the latest commit, it works fine.

I tried to access to the log of the build based on the short extractor commit the branch is based from, and this ran a new build on JitPack. Trying to access the log of the full commit of the commit returned File not found. Build ok, but now works.

I ran the CI again.

@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TobiGr TobiGr merged commit 4070007 into TeamNewPipe:dev Oct 9, 2022
@TacoTheDank TacoTheDank deleted the useSimpleSummaryProvider branch October 10, 2022 17:23
This was referenced Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants