Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Desugaring to 1.1.8 #9481

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Nov 29, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update desugar_jdk_libs 1.1.6 -> 1.1.8 (changelog)

Some other things:

  • Update ACRA 5.9.3 -> 5.9.7 (changelog)
  • Update AGP 7.3.0 -> 7.3.1

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trending and search results would never load while I was trying to test this out. I could consistently reproduce on API 31, API 33 emulated and API 30 on my phone. API 22 emulated works. The commit before yours has no problems. Search suggestions seem to work and if you look in the network tab of Android Studio's app inspection you will see that requests are actually being made for trending and search results, though for some reason the results never show up.

@TacoTheDank
Copy link
Member Author

Interesting 🤔 Let's try 1.1.8 instead.

@TacoTheDank TacoTheDank changed the title Update Desugaring to 1.2.2 Update Desugaring to 1.1.8 Dec 2, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AudricV AudricV requested a review from Stypox December 4, 2022 19:47
@Isira-Seneviratne
Copy link
Member

Isira-Seneviratne commented Dec 5, 2022

Trending and search results would never load while I was trying to test this out. I could consistently reproduce on API 31, API 33 emulated and API 30 on my phone. API 22 emulated works. The commit before yours has no problems. Search suggestions seem to work and if you look in the network tab of Android Studio's app inspection you will see that requests are actually being made for trending and search results, though for some reason the results never show up.

Yeah, it seems to be related to this issue: https://issuetracker.google.com/issues/246512175

I updated the desugar library to 1.2.2 and a similar issue occurred in debug builds (release builds worked fine).

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and with 1.1.8 it works. I hope they'll fix this soon

@Stypox Stypox merged commit 8078620 into TeamNewPipe:dev Dec 31, 2022
@Isira-Seneviratne
Copy link
Member

I tested and with 1.1.8 it works. I hope they'll fix this soon

I believe it's fixed in 2.0, which requires AGP 7.4.

@Stypox Stypox mentioned this pull request Jan 22, 2023
3 tasks
@TacoTheDank TacoTheDank deleted the bumpDesugaring branch February 9, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants