Port to material-ui v1 beta #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a very good start, thank you very much! ❤️ |
Merged
|
@leMaik Have you had a chance to review this PR? I was about to port this over to v1 for one of our CEA projects, but realized that @chaitan94 had already started the work. Thanks! |
|
@m2mathew This PR is now outdated (plenty of breaking changes in material-ui) and not done yet. If you want, we'd really like to see this work to be continued! 💯 Otherwise, I'll port it as soon as I've got time. There is a project where we might need this component later. |
|
Yeah, I was about 15 versions behind on MUI beta. API is much different, but feels great to use. I might have time to dig back into this soon! |
|
I'll close this in favor of #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix #25
Cheers,
chaitan94