Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property passdowns and autoOpen properties #28

Merged
merged 3 commits into from Sep 23, 2019
Merged

Add property passdowns and autoOpen properties #28

merged 3 commits into from Sep 23, 2019

Conversation

TeaSeaLancs
Copy link
Contributor

In this PR we add TimePickerProps and ClockProps as properties to the TimeInput component in order to pass down specific properties to the child components. This helps a lot with theme overrides as it becomes possible to pass classes down.

We also add an autoOpen property to allow for the input to immediately open upon mount.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 96.516% when pulling 310dd50 on Allinthedata:master into c46e234 on TeamWertarbyte:master.

@leMaik
Copy link
Member

leMaik commented Sep 23, 2019

Wow, this is a really great first contribution, @TeaSeaLancs! 🎉 I'll publish a new version asap.

@TeaSeaLancs
Copy link
Contributor Author

Cheers @leMaik :)

@leMaik leMaik merged commit 2ad8adb into TeamWertarbyte:master Sep 23, 2019
leMaik added a commit that referenced this pull request Sep 23, 2019
@leMaik
Copy link
Member

leMaik commented Sep 23, 2019

@TeaSeaLancs Note that I renamed autoOpen to openOnMount

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants