Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phoenix to v0.17.0 (latest), fix config, make tests pass #1730

Merged
merged 4 commits into from
Oct 20, 2015

Conversation

thousandsofthem
Copy link

  • phoenix version 0.17.0 now (latest ). was 0.13.0
  • Regenerated the phoenix app from scratch using all-default built-in generator (mix phoenix.new)
  • Tuned config to match other apps (pool size i.e.)
  • Now all tests passing without warnings
  • Updated elixir 1.0.4 -> 1.0.5
  • Includes Clean up code and update Elixir #1729

@thousandsofthem thousandsofthem changed the title regenerate phoenix from v0.17.0, fix config Update phoenix to v0.17.0 (latest), fix config, make tests pass Aug 24, 2015
@thousandsofthem
Copy link
Author

"Round 11 Preview" numbers are off by factor of ~ten. Primary reason: Wrong pool size (way too low)

@blee-techempower blee-techempower merged commit 15ca7b7 into TechEmpower:master Oct 20, 2015
@thousandsofthem
Copy link
Author

ugh ugh.
There are more recent update present (recently opened and already merged), phoenix 1.0.3 - #1751
This one is outdated - phoenix v0.17.0

@blee-techempower could you please revert merge?

@msmith-techempower
Copy link
Member

@thousandsofthem I'm not sure why GH thinks that this is merged; I just checked master and it is not. You should double-check to make sure, but I think that we are okay on this and GitHub is just being a little weird.

@thousandsofthem
Copy link
Author

¯_(ツ)_/¯

okay, looks like files are untouched so all good here. thanks!

@thousandsofthem thousandsofthem deleted the phoenix-0.17.1 branch October 21, 2015 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants