update PHP Fat-Free Framework #1734

ikkez · 2015-08-30T14:14:37Z

fixed an issue found in the logs and updated to v3.5.0.

blee-techempower · 2015-10-19T17:07:30Z

All test faild.

msmith-techempower · 2015-10-19T17:10:21Z

Ah, the folder names all got changed for round 11.

Basically, I would suggest closing this pull request and opening a new one off of master.

ikkez · 2015-10-19T19:09:27Z

Alright. I've updated the branch. It should be able to merge now.

ikkez · 2015-10-20T11:00:47Z

hm. Is this CI check related to this Framework test? What's the problem?

blee-techempower · 2015-10-20T22:33:12Z

Localtest failed. Here is log. ( http://sprunge.us/SOQY )
Please resolve this issue, so this branch can be merged.

ikkez · 2015-10-21T18:01:57Z

Well actually I have no idea why it's not working. It worked in Round 10 before. What was changed?
I've adjusted a path in the nginx config now. hopefully that was the issue.
In the log you showed me, I noticed this notice:
Setup fat-free: [20-Oct-2015 15:29:49] NOTICE: PHP message: PHP Warning: PHP Startup: Unable to load dynamic library '/home/blee/FrameworkBenchmarks/installs/php-5.5.17/lib/php/extensions/no-debug-non-zts-20121212/yaf.so' - /home/blee/FrameworkBenchmarks/installs/php-5.5.17/lib/php/extensions/no-debug-non-zts-20121212/yaf.so: cannot open shared object file: No such file or directory in Unknown on line 0
is that relevant? It does not seem to belong to our framework. why was this tried to be loaded?

hamiltont · 2015-10-29T22:17:16Z

@msmith-techempower Is there a readme we can point to that helps explain all the reasons why we don't like PRs with the source code for the entire framework included?

@ikkez Some context: all other frameworks (besides the 5-10 that have yet been updated, incl. fatfree) do not put their entire framework source code directly in the TFB repo, that is downloaded by the setup.sh script. Is this something you could add to this PR?

msmith-techempower · 2015-10-29T22:42:50Z

@hamiltont Not to my knowledge... but there isn't much of that anyway.

hamiltont · 2015-10-29T22:54:36Z

not anymore ;-)

ikkez · 2015-10-30T13:49:46Z

@hamiltont really? As far as I can see others have included the source files as well, and fat-free is one of those with a relative small code base (~150kb, hand-picked for this tests). I can remove the changelog file to save additional 30kb if you want. I am currently more interested in getting the test-suite running instead of setup optimizations. I guess I'm lost with both tasks.

Rayne · 2015-11-18T22:11:31Z

My Vagrant box returns the following result with f3-factory@4c03423:

toolset/run-tests.py --install server --mode verify --test fat-free

[…]

================================================================================
  Verification Summary

| Test: fat-free
|       plaintext   : WARN
|       query       : PASS
|       json        : PASS
|       db          : WARN
|       update      : PASS
================================================================================

The Travis CI runner instead fails because of ./toolset/run-ci.py prereq "$TESTDIR" terminating with exit code 1 (run-tests.py#L176-L186, see also the caller terminating at run-ci.py#L323-L326).

I haven't found a solution in the documentation or a similar problem in Google Groups. Do you have an idea how to fix this problem?

Also I would like to reset our master branch to create a new pull request (as suggested by @msmith-techempower) on a dedicated branch (probably this branch) after resolving the mentioned problems.

ikkez · 2015-11-19T07:56:54Z

Also I would like to reset our master branch... as suggested by msmith-techempower

@Rayne I did that already and force-pushed it into the current master that is used in this pull-request. There should be no merge conflicts anymore.

Rayne · 2015-11-19T20:29:46Z

Java/sabina has the same problem.

@ikkez You are right that there aren't merge conflicts, but our master branch isn't deployable and diverges from TechEmpower's master branch.

There's only one rule: anything in the master branch is always deployable.

Because of this, it's extremely important that your new branch is created off of master when working on a feature or a fix.

Source: https://guides.github.com/introduction/flow/index.html

msmith-techempower · 2015-12-10T17:03:39Z

@ikkez @Rayne We have recently made a number of fixes for Travis-CI on our master; can you please rebase and push your branch so that Travis-CI will automatically test for us?

ikkez · 2015-12-10T19:23:03Z

it's rebased now.

msmith-techempower · 2015-12-10T19:24:20Z

Awesome!

ikkez · 2015-12-11T09:57:11Z

Can I find the complete travis ci error logs somewhere? I'm looking for the full response of this test: https://travis-ci.org/F3Community/FrameworkBenchmarks/jobs/96214489#L1701
seems like it's the every last one to fix, the others are green now :)

ikkez · 2015-12-11T16:15:34Z

Fat-Free uses a strict error_reporting setting by default. Because Php yaf seems to be installed globally as a php module #1521 and randomly fails to load, our error handler is triggered and shouts things like this:

Server fat-free: 2015/12/11 15:04:49 [error] 28739#0: *2 FastCGI sent in stderr: "PHP message: Fatal error: PHP Startup: Unable to load dynamic library '/home/vagrant/FrameworkBenchmarks/installs/php-5.5.17/lib/php/extensions/no-debug-non-zts-20121212/yaf.so' - /home/vagrant/FrameworkBenchmarks/installs/php-5.5.17/lib/php/extensions/no-debug-non-zts-20121212/yaf.so: cannot open shared object file: No such file or directory" while reading response header from upstream, client: 127.0.0.1, server: localhost, request: "GET /db-orm HTTP/1.1", upstream: "fastcgi://127.0.0.1:9001", host: "127.0.0.1:8080"

Because of this, your test verification randomly fails... sometimes. Of course we don't need yaf, and we could probably adjust the error reporting level to get around this, but I don't see that our framework should clean up install requirements or ignore errors from others participants.

msmith-techempower · 2015-12-11T16:29:13Z

Hmm, I'm not convinced that yaf is the problem.

@ssmith-techempower Could you pull this and test locally; at least this will output error logs that can be attached to the task to better understand the issue.

ikkez · 2015-12-11T17:45:42Z

Fat-Free scans for already occurred system errors on its initialization. We already have a similar issue here bcosca/fatfree#851 which reveals a server issue before F3 starts. A way to clear system errors is to use the error_clear_last(); function, but it's only available with PHP7.

msmith-techempower · 2016-01-13T17:49:40Z

frameworks/PHP/fat-free/benchmark_config.json

@@ -43,6 +43,49 @@
      "display_name": "fat-free",
      "notes": "",
      "versus": "php"
+    },
+    "php5": {
+      "setup_file": "setup",


This should be "setup_file": "setup_php5"

oh yes, indeed. thanks.

msmith-techempower · 2016-01-18T16:39:19Z

I'm not quite sure what happened on Travis; it got into the fat-free-php5 test, successfully installed php5 and nginx, then just stopped doing work entirely so the job timed out.

I see the line nginx is installed! in the Travis log, so it definitely finished its fw_depends calls, but the next call should have been sed, and it never got to that... curious.

ikkez · 2016-01-18T18:05:40Z

hm, should I just try to drop the php5 test for now, to see if it works, or will it be out of comparison with other frameworks, which are not using php7 already?

msmith-techempower · 2016-01-25T16:59:21Z

Hmm, according to the log, it seems that there is still this timeout issue.

I'm not really sure what is going on here, but it's hanging up in Travis-CI.

msmith-techempower · 2016-03-14T16:43:23Z

Seems that there is STILL a hang-up in Travis and I am not sure why.

@ssmith-techempower Can you test all the fat-free variants locally and report back?

…etup.sh`

ssmith-techempower · 2016-03-15T16:11:34Z

It's timing out my local install as well. Gets to "nginx is installed!" and then hangs.

msmith-techempower · 2016-03-15T16:13:33Z

Thanks - it's odd that of all the PHP tests, this is the only one hanging in this way.

ssmith-techempower · 2016-03-15T16:31:08Z

frameworks/PHP/fat-free/setup.sh

+
+F3DIR="$TROOT/src"
+
+[[ ! -e "$F3DIR" ]] || rm -r "$F3DIR"


The rm command here needs the f flag to force the rm to happen without bringing up a prompt, which was hanging Travis and my local install due to prompting about write-protected files.

TechEmpower#1734 (diff)

ikkez · 2016-03-16T14:23:30Z

looks good here https://travis-ci.org/F3Community/FrameworkBenchmarks/jobs/116216563
thank you all for the support :)

ssmith-techempower · 2016-03-16T19:48:12Z

Looks good on my local install, and I trust your Travis job means it would succeed for us. Merging in.

update PHP Fat-Free Framework

ikkez force-pushed the master branch from f6e7170 to 8b5ce6b Compare October 19, 2015 19:08

blee-techempower force-pushed the master branch from 05fbfd0 to d5b976a Compare October 21, 2015 10:23

ikkez mentioned this pull request Nov 17, 2015

update benchmark tests f3-factory/FrameworkBenchmarks#3

Closed

msmith-techempower added PR: Please Update PR: LGTM if Travis-CI agrees! labels Dec 10, 2015

ikkez force-pushed the master branch from 4c03423 to e692af7 Compare December 10, 2015 19:21

msmith-techempower removed the PR: Please Update label Dec 10, 2015

msmith-techempower assigned ssmith-techempower Dec 11, 2015

msmith-techempower added Bug: Framework and removed PR: LGTM if Travis-CI agrees! labels Dec 11, 2015

msmith-techempower reviewed Jan 13, 2016
View reviewed changes

msmith-techempower removed the Bug: Framework label Jan 18, 2016

ikkez force-pushed the master branch from ea5ace6 to 8637d2d Compare February 8, 2016 16:31

ikkez mentioned this pull request Feb 29, 2016

checking for system errors on Base initialization bcosca/fatfree#851

Closed

ikkez and others added 12 commits March 15, 2016 12:04

update libs and test for TFB-Round-11, 2nd try

bbb6fd1

fix root path

fcce456

Removed unused Apache configuration

3785d46

Removed the included source code of Fat-Free Framework and updated `s…

7b9c562

…etup.sh`

update tests and config

5cced15

simplify error out

1ca06df

add php7 support

4603aa2

drop startup errors in php7

d5d8adb

fix php5 setup config

1604b98

drop php5 config for testing

b82b18d

adjust config

6b65758

update framework, adjust error level

273afe5

ikkez force-pushed the master branch from 8637d2d to 273afe5 Compare March 15, 2016 11:38

ssmith-techempower reviewed Mar 15, 2016
View reviewed changes

msmith-techempower added the PR: LGTM if Travis-CI agrees! label Mar 15, 2016

php/fat-free: Force remove existing library files

8822fe2

TechEmpower#1734 (diff)

ssmith-techempower added a commit that referenced this pull request Mar 16, 2016

Merge pull request #1734 from F3Community/master

b2aa669

update PHP Fat-Free Framework

ssmith-techempower merged commit b2aa669 into TechEmpower:master Mar 16, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update PHP Fat-Free Framework #1734

update PHP Fat-Free Framework #1734

ikkez commented Aug 30, 2015

blee-techempower commented Oct 19, 2015

msmith-techempower commented Oct 19, 2015

ikkez commented Oct 19, 2015

ikkez commented Oct 20, 2015

blee-techempower commented Oct 20, 2015

ikkez commented Oct 21, 2015

hamiltont commented Oct 29, 2015

msmith-techempower commented Oct 29, 2015

hamiltont commented Oct 29, 2015

ikkez commented Oct 30, 2015

Rayne commented Nov 18, 2015

ikkez commented Nov 19, 2015

Rayne commented Nov 19, 2015

msmith-techempower commented Dec 10, 2015

ikkez commented Dec 10, 2015

msmith-techempower commented Dec 10, 2015

ikkez commented Dec 11, 2015

ikkez commented Dec 11, 2015

msmith-techempower commented Dec 11, 2015

ikkez commented Dec 11, 2015

msmith-techempower Jan 13, 2016

ikkez Jan 13, 2016

msmith-techempower commented Jan 18, 2016

ikkez commented Jan 18, 2016

msmith-techempower commented Jan 25, 2016

msmith-techempower commented Mar 14, 2016

ssmith-techempower commented Mar 15, 2016

msmith-techempower commented Mar 15, 2016

ssmith-techempower Mar 15, 2016

ikkez commented Mar 16, 2016

ssmith-techempower commented Mar 16, 2016

update PHP Fat-Free Framework #1734

update PHP Fat-Free Framework #1734

Conversation

ikkez commented Aug 30, 2015

blee-techempower commented Oct 19, 2015

msmith-techempower commented Oct 19, 2015

ikkez commented Oct 19, 2015

ikkez commented Oct 20, 2015

blee-techempower commented Oct 20, 2015

ikkez commented Oct 21, 2015

hamiltont commented Oct 29, 2015

msmith-techempower commented Oct 29, 2015

hamiltont commented Oct 29, 2015

ikkez commented Oct 30, 2015

Rayne commented Nov 18, 2015

ikkez commented Nov 19, 2015

Rayne commented Nov 19, 2015

msmith-techempower commented Dec 10, 2015

ikkez commented Dec 10, 2015

msmith-techempower commented Dec 10, 2015

ikkez commented Dec 11, 2015

ikkez commented Dec 11, 2015

msmith-techempower commented Dec 11, 2015

ikkez commented Dec 11, 2015

msmith-techempower Jan 13, 2016

Choose a reason for hiding this comment

ikkez Jan 13, 2016

Choose a reason for hiding this comment

msmith-techempower commented Jan 18, 2016

ikkez commented Jan 18, 2016

msmith-techempower commented Jan 25, 2016

msmith-techempower commented Mar 14, 2016

ssmith-techempower commented Mar 15, 2016

msmith-techempower commented Mar 15, 2016

ssmith-techempower Mar 15, 2016

Choose a reason for hiding this comment

ikkez commented Mar 16, 2016

ssmith-techempower commented Mar 16, 2016