Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update framework version to 1.3.5 #1761

Merged
merged 12 commits into from
Dec 11, 2015
Merged

Update framework version to 1.3.5 #1761

merged 12 commits into from
Dec 11, 2015

Conversation

jaguililla
Copy link
Contributor

No description provided.

@blee-techempower
Copy link
Contributor

3 tests: fortune, db, query failed.

 Verification Summary
| Test: sabina
|       fortune     : FAIL
|       plaintext   : PASS
|       db          : FAIL
|       update      : PASS
|       json        : PASS
|       query       : FAIL

@jaguililla
Copy link
Contributor Author

I would like to request some help here. When I run the tests from my fork (inside the vagrant-development VM) they pass, but they always fail in Travis.

How could I replay the error in my local environment?

@msmith-techempower
Copy link
Member

We still have issues with Travis that need to be addressed - we will check this out and run it locally to test it before merging, rather than relying on Travis.

@jaguililla
Copy link
Contributor Author

Ok, thank you for the information!

@Rayne Rayne mentioned this pull request Nov 19, 2015
Merged
@jaguililla
Copy link
Contributor Author

Retest this please

@jaguililla
Copy link
Contributor Author

Could you please send an update about the Travis problems? should I pick your latest master changes?

mwpastore and others added 4 commits December 2, 2015 01:28
@mwpastore
sinatra-sequel on JRuby
3dc9d5d 
* Make sinatra-sequel framework compatible with JRuby 9K
* Add runner, language setup, and benchmark config for
  sinatra-sequel-puma-jruby
* Bug Fix: sinatra-sequel framework was applying updates on /updates,
  but returning the original records (instead of the updated records)
* Incorporated findings from StackProf analysis and clearer reading of
  Sequel documentation
@NateBrady23
Merge pull request TechEmpower#1787 from mwpastore/master
e4a815d 
Add sinatra-sequel-puma-jruby benchmark
@NateBrady23
Merge pull request TechEmpower#1769 from sanjoydesk/master
b47a396 
Updated composer.json to pull Cygnite v1.3
@msmith-techempower
Merge pull request TechEmpower#1786 from TechEmpower/travis-fixes-work
4d7dbc9 
Trying to fix Travis
@msmith-techempower
Copy link
Member

@jamming We have just pushed a bunch of Travis-CI fixes into master; if you could rebase your branch from our master and push the changes, Travis-CI should be able to test automatically.

@jaguililla
Copy link
Contributor Author

Mmmm... My framework pass the tests but others don't, will it be merged?

@msmith-techempower
Copy link
Member

Yes, your tests pass: https://travis-ci.org/TechEmpower/FrameworkBenchmarks/jobs/96141934

LGTM!

msmith-techempower added a commit that referenced this pull request Dec 11, 2015
@msmith-techempower
Merge pull request #1761 from jamming/sabina-1.3.4
26a75a8 
Update framework version to 1.3.5
@msmith-techempower msmith-techempower merged commit 26a75a8 into TechEmpower:master Dec 11, 2015
@jaguililla jaguililla deleted the sabina-1.3.4 branch May 11, 2016 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Please Update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jaguililla @blee-techempower @msmith-techempower @juanjoaguililla @sanjoydesk @mwpastore @NateBrady23