New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade version of crystal to 0.8.0 #1746
Conversation
829c058
to
8c617b2
Compare
For some reason redis is working locally but not on these tests. But it has postgres support - which is a better benchmark for comparing with other tests. |
@zane-techempower was your thought that 1 program would serve all 3 database types? Ideas why redis would be failing? It looks like it is not getting configured correctly. (I used the techempower script to populate my redis) Thanks |
This is flexible, endpoints of a certain db can be separated by their route, e.g.
I believe you when you say that redis is working just fine locally, as we are aware of redis having issues on travis.ci. On travis, redis is set up in its own way, different to our other test environments, which is leading to erroneously failing tests. Fixing up the redis bug on travis is on my todo-list but I have not had time amongst my other responsibilities. Travis does great work for us, and this redis issue is a small unfortunate thing. Two things can happen now:
Thanks for the work! Crystal is a favorite of mine :) |
Pass all localtests. Looks good.
|
upgrade version of crystal to 0.8.0
add postgres support too