Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Ktor using an async database layer #4247

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

Whoops
Copy link
Contributor

@Whoops Whoops commented Dec 9, 2018

This adds a couple additional tests with Ktor, but using non-blocking database clients. In theory this should reduce the overhead of using blocking JDBC calls with a work pool.

I actually went ahead and implemented two different clients since I'm curious how they perform. Jasync-sql is interesting in that it has Kotlin coroutines integration, which makes the code actually more natural than the JDBC based tests. Reactive-PG-Client seems more feature full, and is the same client used in the Vert.x tests.

@NateBrady23
Copy link
Member

Since this is a permutation for ktor, we'd prefer this to be in the Kotlin/ktor directory. You can add these tests to that benchmark_config.json

@Whoops
Copy link
Contributor Author

Whoops commented Dec 11, 2018

Done, I've moved it and the existing tests into subdirectories under the existing ktor directory. I'm hoping that approach is acceptable, and I'm not sure how I'd integrate them into a single build.

@NateBrady23
Copy link
Member

Yeah, that approach is great. No need to make them a single build.

@NateBrady23 NateBrady23 merged commit d3644b8 into TechEmpower:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants