Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-end: Fix the CI builds #324

Closed
OrAbramovich opened this issue Apr 24, 2018 · 3 comments
Closed

Back-end: Fix the CI builds #324

OrAbramovich opened this issue Apr 24, 2018 · 3 comments

Comments

@OrAbramovich
Copy link
Collaborator

OrAbramovich commented Apr 24, 2018

For some reason the Travis-CI build started to fail during the npm install phase. Understand why & resolve! We must have a continuous integration. It's top priority.

@OrAbramovich
Copy link
Collaborator Author

Estimated time: 1 hour

OrAbramovich added a commit that referenced this issue Apr 24, 2018
Looks there is a new and unnecessary  dependency - deasync so I removed it.

#324
OrAbramovich added a commit that referenced this issue Apr 24, 2018
Additional removals of same redundant dependency leftovers (from package-lock.json) that might cause the failures.

#324
OrAbramovich added a commit that referenced this issue Apr 24, 2018
Reverted previous changes since it didn't help.
Tried to re-add it.

#324
OrAbramovich added a commit that referenced this issue Apr 24, 2018
Defined Travis to work with node 9 since I notices that it started to use node 10.

#324
@OrAbramovich
Copy link
Collaborator Author

Actual time: 1 hour.

@OrAbramovich
Copy link
Collaborator Author

The reason: TravisCI started to use node js version 10 and one of our dependencies can't be installed on top of it so I configured the CI to build with node js version 9.

@chananbental - it's something that you added - deasync - what is it? Is there an alternative that can wotk with node 10?

Anyway - TravisCI is back to life (with version 9) and re-builds the project on every commit.

Done.

@OrAbramovich OrAbramovich changed the title Back-end: Fix the CI build Back-end: Fix the CI builds Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant