Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: Notify user about new apartments he might be interested in #335

Closed
OrAbramovich opened this issue Apr 27, 2018 · 10 comments
Closed
Assignees
Labels
Projects

Comments

@OrAbramovich
Copy link
Collaborator

OrAbramovich commented Apr 27, 2018

New feature: the platform should be able to notify (notification + email) a registered user about new apartments he might be interested in according to his last searches. The task is writing a design document for the feature.

@OrAbramovich OrAbramovich added this to the Mid Semester POC milestone Apr 27, 2018
@OrAbramovich OrAbramovich self-assigned this Apr 27, 2018
@OrAbramovich OrAbramovich added this to Backlog in Roommates via automation Apr 27, 2018
@OrAbramovich OrAbramovich removed their assignment May 4, 2018
@OrAbramovich
Copy link
Collaborator Author

The suggestion should be based on past history search.

@OrAbramovich
Copy link
Collaborator Author

Estimated time: 2 hours.

@OrAbramovich OrAbramovich moved this from Backlog to To do (planned for this week but not started) in Roommates May 22, 2018
@chananbental
Copy link
Collaborator

a sektch for the design:
save in a tree formation all the users acoording to search:
have 1 main json that saves an array of data for every country, every countrywill save an array of cities, and so on for each search parameter.

  • search history{

    • country array [

      • city array [

        • price_range array [

          • users array [
            * user1,
            * user2,
            * user3

          ]

        ]

      ]

    ]

}
when ever a new apartment is added we will check the coorsopnding search in the search tree to find the list of users that searched for this kind of apartment.

what do you think of this as a base?

@chananbental
Copy link
Collaborator

chananbental commented May 23, 2018

please disregard the previous comment.
i have started writing the document.
progress can be seen here
happy to recive feedback at any point.

@chananbental chananbental moved this from To do (planned for this week but not started) to In progress (started and working on it this week) in Roommates May 24, 2018
@chananbental
Copy link
Collaborator

i think i am finished, waiting for OK from @OrAbramovich
should i add the back end API?
link to doc is in previous comment

@OrAbramovich
Copy link
Collaborator Author

OrAbramovich commented May 25, 2018

Hi @chananbental ,

First of all - it looks good. We can actually derive the API and it looks that your design fits the current flow of the system.

In my opinion, the following are missing:

  1. The actual flow (e.g apartment is added -> the system looks for relevant searches (immediately/once a...).

  2. More details (e.g "we need to save the searchs parameters: location, price range, number of rooms, basically all info used in searchs" - how? what is the structure?").

  3. I think it would be great if you could write other implementation alternatives along with the pros and cons of each one so we can understand the reasons and considerations for choosing the specific one.

What do you think?

@chananbental
Copy link
Collaborator

Sounds like a good idea.
Ill get on it once i ginish the nust, should be very soon

@chananbental
Copy link
Collaborator

chananbental commented May 27, 2018

image

image

this is here for the design document

@chananbental
Copy link
Collaborator

chananbental commented May 29, 2018

actual time 4 hours
waiting for final OK

@omrihuller omrihuller moved this from In progress (started and working on it this week) to Backlog in Roommates May 29, 2018
@chananbental
Copy link
Collaborator

done
working on implementaion #534

Roommates automation moved this from Backlog to Done Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Roommates
  
Done
Development

No branches or pull requests

2 participants