Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back-end: Sockets-server: Support authentication with second roundtrip #386

Closed
OrAbramovich opened this issue May 7, 2018 · 4 comments
Closed

Back-end: Sockets-server: Support authentication with second roundtrip #386

OrAbramovich opened this issue May 7, 2018 · 4 comments
Assignees
@OrAbramovich @alonttal
Labels
Back-End
Milestone
Mid Semester POC

Comments

@OrAbramovich
Copy link
Collaborator

No description provided.

@OrAbramovich OrAbramovich added this to the Mid Semester POC milestone May 7, 2018
@OrAbramovich
Copy link
Collaborator Author

OrAbramovich commented May 7, 2018 •
edited
Loading

Time estimation: 2 hours.

@OrAbramovich OrAbramovich mentioned this issue May 7, 2018
Closed
@OrAbramovich
Copy link
Collaborator Author

After a lot of investigations -
The front-end & back-end authentication problem was caused by the fact that the front-end performed the a 2 roundtrip authentication and the sockets server didn't allow it (only 1 way was approved i.e. during the initialization).

@OrAbramovich
Copy link
Collaborator Author

Code was written on Alon's laptop - will be pushed by him.

alonttal added a commit that referenced this issue May 7, 2018
@alonttal
Back-end:
efaa94a 
	-sockets: authentication can now be established not on socket
	creation.
Front-end:
	- socket integration with back-end is finally working !!!
	- change the notification component to work with the
	notifications schema.
	- fetching self on creation if authenticated.
issues: #382 #386 #388
@OrAbramovich OrAbramovich mentioned this issue May 7, 2018
Open
@alonttal alonttal mentioned this issue May 7, 2018
Open
@alonttal
Copy link
Collaborator

alonttal commented May 8, 2018

done.
Actual time: 2.5 hours

@alonttal alonttal closed this as completed May 8, 2018
@alonttal alonttal mentioned this issue May 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OrAbramovich OrAbramovich

@alonttal alonttal

Labels
Back-End
Projects
None yet
Milestone
Mid Semester POC
Development

No branches or pull requests
2 participants
@OrAbramovich @alonttal