Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Group"s tests #537

Closed
alonttal opened this issue Jun 5, 2018 · 1 comment
Closed

"Group"s tests #537

alonttal opened this issue Jun 5, 2018 · 1 comment

Comments

@alonttal
Copy link
Collaborator

alonttal commented Jun 5, 2018

estimate time: 5 hours

@alonttal alonttal self-assigned this Jun 5, 2018
@alonttal alonttal added this to Backlog in Roommates via automation Jun 5, 2018
@alonttal alonttal added this to the End of Semester Demo milestone Jun 5, 2018
@alonttal alonttal moved this from Backlog to In progress (started and working on it this week) in Roommates Jun 5, 2018
alonttal added a commit that referenced this issue Jun 6, 2018
- added group tests that checks group status invariants.
- added patch route tests.
- added updateMemberStatus method to apartment model.
- added PATCH /apartments/:id/groups route.
- added new errors: groupNotFound, groupMemberNotFound.
issues: #526 #529 #537 #151
alonttal added a commit that referenced this issue Jun 9, 2018
- creating a new group is now using the best match algorithm.
- updated tests
issue: #528 #537
@alonttal alonttal changed the title create group tests "Group"s tests Jun 9, 2018
@alonttal
Copy link
Collaborator Author

alonttal commented Jun 9, 2018

Added tests for:

  • group status change (keep group invariant).
  • GET /apartment/:id/groups route.
  • POST /apartment/:id/groups route.
  • PATCH /apartment/:id/groups route.

total time: 4 hours.
closed.

@alonttal alonttal closed this as completed Jun 9, 2018
Roommates automation moved this from In progress (started and working on it this week) to Done Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roommates
  
Done
Development

No branches or pull requests

1 participant