Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error module for handling errors #151

Closed
alonttal opened this issue Jan 13, 2018 · 1 comment
Closed

Add error module for handling errors #151

alonttal opened this issue Jan 13, 2018 · 1 comment
Labels
Back-End

Comments

@alonttal
Copy link
Collaborator

the error will contain:
code,
message

and it will be sent to client upon error.
@alonttal alonttal self-assigned this Jan 13, 2018
@alonttal alonttal mentioned this issue Jan 13, 2018
Open
alonttal added a commit that referenced this issue Jun 6, 2018
@alonttal
back-end:
3db5773 
- added group tests that checks group status invariants.
- added patch route tests.
- added updateMemberStatus method to apartment model.
- added PATCH /apartments/:id/groups route.
- added new errors: groupNotFound, groupMemberNotFound.
issues: #526 #529 #537 #151
alonttal added a commit that referenced this issue Jun 9, 2018
@alonttal
Back-end:
740047d 
- added new Error: userUpdateFailure
- fixed failing tests after group addition.

Front-end:

issues:  #151 #540 #542
@alonttal alonttal removed their assignment Jun 13, 2018
alonttal added a commit that referenced this issue Jun 16, 2018
@alonttal
Back-end:
1cdb98c 
- Added "sign" method for signing a group.
- Added new error - groupSignFailure
issue: #585 #151
alonttal added a commit that referenced this issue Jun 16, 2018
@alonttal
Back-end:
8b00ec4 
- Added PATCH /apartments/:id/groups/sign to sign a group
- Added new error - groupInvalidSigner
issues: #586 #151
@OrAbramovich
Copy link
Collaborator

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Back-End
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OrAbramovich @alonttal