Pin nodejs versions for pre-commit #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 32d9d6b.
joao-p-marques
approved these changes
Oct 23, 2020
yajo
added
the
automerge
This seems to be a better fix (for now) than #149 because it just fixes the npm 7 installation problem without having to worry about prettier/pre-commit#17 or prettier/pre-commit#18 for the moment. Once those are solved, we can start using the new repo. Updated prettier BTW.
yajo
force-pushed
the
prettier-install-fix
branch
from
da823a2
to
702b838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a better fix (for now) than #149 because it just fixes the npm 7 installation problem without having to worry about prettier/pre-commit#17 or prettier/pre-commit#18 for the moment.
Once those are solved, we can start using the new repo.